[MM-47779] Prevent crash when either URL view or main window was destroyed first (#2300)

2022-10-21 09:19:33 -04:00
parent f7f38102d8
commit dc49003d38
1 changed files with 5 additions and 1 deletions
--- a/src/main/views/viewManager.ts
+++ b/src/main/views/viewManager.ts
@@ -373,7 +373,11 @@ export class ViewManager {

            const hideView = () => {
                delete this.urlViewCancel;
-                this.mainWindow.removeBrowserView(urlView);
+                try {
+                    this.mainWindow.removeBrowserView(urlView);
+                } catch (e) {
+                    log.error('Failed to remove URL view', e);
+                }

                // workaround to eliminate zombie processes
                // https://github.com/mattermost/desktop/pull/1519