From dc49003d387303fe384052cc35c80b953674ed5a Mon Sep 17 00:00:00 2001 From: Devin Binnie <52460000+devinbinnie@users.noreply.github.com> Date: Fri, 21 Oct 2022 09:19:33 -0400 Subject: [PATCH] [MM-47779] Prevent crash when either URL view or main window was destroyed first (#2300) --- src/main/views/viewManager.ts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/main/views/viewManager.ts b/src/main/views/viewManager.ts index da85d9e9..089263e1 100644 --- a/src/main/views/viewManager.ts +++ b/src/main/views/viewManager.ts @@ -373,7 +373,11 @@ export class ViewManager { const hideView = () => { delete this.urlViewCancel; - this.mainWindow.removeBrowserView(urlView); + try { + this.mainWindow.removeBrowserView(urlView); + } catch (e) { + log.error('Failed to remove URL view', e); + } // workaround to eliminate zombie processes // https://github.com/mattermost/desktop/pull/1519