phlux/mattermostest
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Remove unnecessary code that disabled Certificate Transparency verification

Browse Source
This commit is contained in:
Yuya Ochiai
2018-04-02 20:38:43 +09:00
parent a88a50e780
commit 7008ee318e
1 changed files with 0 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/main.js
View File

@@ -15,7 +15,6 @@ const {
} = require('electron');
const isDev = require('electron-is-dev');
const installExtension = require('electron-devtools-installer');
const semver = require('semver');
const parseArgv = require('yargs').parse;
const protocols = require('../electron-builder.json').protocols;
@@ -625,20 +624,6 @@ app.on('ready', () => {
permissionManager = new PermissionManager(permissionFile, trustedURLs);
session.defaultSession.setPermissionRequestHandler(permissionRequestHandler(mainWindow, permissionManager));
// Disable Certificate Transparency until Electron 1.8.3
// due to https://github.com/electron/electron/issues/11997
if (semver.lt(process.versions.electron, '1.8.3')) {
const SUCCESS_AND_DISABLE_CERTIFICATE_TRANSPARENCY = 0;
const USE_VERIFICATION_RESULT_FROM_CHROMIUM = -3;
session.defaultSession.setCertificateVerifyProc((request, callback) => {
if (request.verificationResult === 'net::OK') {
callback(SUCCESS_AND_DISABLE_CERTIFICATE_TRANSPARENCY);
} else {
callback(USE_VERIFICATION_RESULT_FROM_CHROMIUM);
}
});
}
// Open the DevTools.
// mainWindow.openDevTools();
});