From 7008ee318e7bac3067fef8b185cc3bb1290861c3 Mon Sep 17 00:00:00 2001 From: Yuya Ochiai Date: Mon, 2 Apr 2018 20:38:43 +0900 Subject: [PATCH] Remove unnecessary code that disabled Certificate Transparency verification --- src/main.js | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/src/main.js b/src/main.js index e9f2dabc..8dded718 100644 --- a/src/main.js +++ b/src/main.js @@ -15,7 +15,6 @@ const { } = require('electron'); const isDev = require('electron-is-dev'); const installExtension = require('electron-devtools-installer'); -const semver = require('semver'); const parseArgv = require('yargs').parse; const protocols = require('../electron-builder.json').protocols; @@ -625,20 +624,6 @@ app.on('ready', () => { permissionManager = new PermissionManager(permissionFile, trustedURLs); session.defaultSession.setPermissionRequestHandler(permissionRequestHandler(mainWindow, permissionManager)); - // Disable Certificate Transparency until Electron 1.8.3 - // due to https://github.com/electron/electron/issues/11997 - if (semver.lt(process.versions.electron, '1.8.3')) { - const SUCCESS_AND_DISABLE_CERTIFICATE_TRANSPARENCY = 0; - const USE_VERIFICATION_RESULT_FROM_CHROMIUM = -3; - session.defaultSession.setCertificateVerifyProc((request, callback) => { - if (request.verificationResult === 'net::OK') { - callback(SUCCESS_AND_DISABLE_CERTIFICATE_TRANSPARENCY); - } else { - callback(USE_VERIFICATION_RESULT_FROM_CHROMIUM); - } - }); - } - // Open the DevTools. // mainWindow.openDevTools(); });