Commit Graph

81 Commits

Author SHA1 Message Date
FalseHonesty
5d0a937bb9 [MM-21835] Use URL instead of the url library (#1384)
Additionally, migrate all of the URL related helper functions
from `src/utils/utils.js` to the new `src/utils/url.js` file
and migrate tests.

Issue MM-21835
Fixes #1206
2020-11-04 20:59:07 +01:00
Guillermo Vayá
9ceb38402a [MM-29677] fix download complete notification not appearing (#1388) 2020-10-14 22:42:08 +02:00
Nathan Bolender
2198244a65 [MM-9922] Hide tooltip for internal links (channels, timestamps, etc.) (#1386)
* Hide tooltip for internal links (channels, timestamps, etc.)

* Only hide tooltip for internal links on the *current* team
2020-10-14 17:06:11 +02:00
Guillermo Vayá
a30233f913 [MM-26017] add menu to all windows (#1327)
* [MM-26017] add menu to all windows

* fix suggestions

* fix internal images
2020-06-26 21:20:21 +02:00
Devin Binnie
81522a3b2d [MM-22751] Removed Windows 10 style border for non-Windows 10 clients (#1322)
* [MM-22751] Removed Windows 10 style border for non-Windows 10 clients

* Lint fix
2020-06-17 20:54:42 +02:00
Guillermo Vayá
d49e8dd501 [MM-25980] no menu for popups (#1323)
* [MM-25980] remove menu for win and linux

* [MM-25980] fix focus error

* revert menu visibility on popup
2020-06-17 10:42:28 +02:00
Guillermo Vayá
a377ac2a12 [MM-25429]/[MM-25433] fix finder focus, align buttons, keep state consistent (#1301)
* [MM-25429] fix finder focus, align buttons, keep state consistent

* wip

* actually fix the problem

* remove logs

* move finder class with the rest of the classes, back to top

* address ux comments
2020-06-03 10:42:09 +02:00
Devin Binnie
4ce0ede8b7 [MM-25522] Revert unnecessary fix for bad UX causing focus to not be restored correctly (#1303) 2020-05-28 11:28:42 -07:00
Guillermo Vayá
36c6106cad [MM-22648] basic auth external sites (#1295)
* fix not using babel

* wip

* added tests, moved to map, polifill-like to convert between object and map

* basic structure setup

* working, found new bug

* change buttons

* fix login issue

* remove logging code

* address CR comments

* remove custom function in favor of airbnb shim

* fix linting

* fix PM requested changes

* [MM-25323] fix basic auth cancelling

* fix crash when multiple request were made

* address UX comments, added external link for user
convenience
2020-05-28 10:53:57 +02:00
Guillermo Vayá
c2102bb257 [MM-22102] upgrade to electron 7 (#1268)
* fix errors

* upgrade to electron 7

* getsavepath is deprecated

* fix typo

* disable messaging from 'null'

* replace getname to its property

* deprecated zoomlevel

* deprecated setbadgecount

* isdarkmode deprecated

* it's a property, not a function

* fix error message

* fix test

* fix test on linux
2020-05-09 00:29:02 +02:00
Guillermo Vayá
cc78da7d2c [MM-23215] prevent mouse event to go through and click on window (#1269) 2020-04-22 19:08:54 +02:00
Devin Binnie
9b5f53a294 [MM-22720] Assume maximize setting when AppleActionOnDoubleClick isn't explicitly set (#1214)
* [MM-22720] Assume maximize setting when AppleActionOnDoubleClick isn't explicitly set

* Forced for macOS only and made same changes to SettingsPage

Co-authored-by: mattermod <mattermod@users.noreply.github.com>
2020-04-07 14:52:33 -04:00
Guillermo Vayá
c24354f367 [MM022677] fix focus on new server modal (#1242) 2020-04-02 14:50:23 +02:00
Nev Angelova
3d188030a4 [MM-22363] - Add desktop notification on download complete (#1213)
* [MM-22363] - Add desktop notification on download complete

* Fix notifications on windows

* Add missing shell import

* Add missing log1

* Solve file location bug

* remove console.log

* Resolve PR comments1

* transform server origin to server name

* please linter

* remove redundant parameters from download notification

* refactor the notification click handling to use a callback

Co-authored-by: Nevyana <nevyana@Nevyanas-MacBook-Pro.local>
Co-authored-by: Nevyana Angelova <nevyangelova@Nevyanas-MBP.fritz.box>
Co-authored-by: mattermod <mattermod@users.noreply.github.com>
2020-04-01 16:29:33 +02:00
Devin Binnie
cb6244832a [MM-22479] Added aria-label to 3-dot menu on Windows (#1244) 2020-03-26 14:24:08 -04:00
Devin Binnie
a24d21e819 [MM-20742] Null checking on URL pathname when deep linking (#1243)
* [MM-20742] Null checking on URL pathname when deep linking

* Switched to using '/' instead of blank string
2020-03-25 12:41:57 -04:00
Guillermo Vayá
cfd65d62c6 [MM-19856] Add back button when navigating outside of MM server (#1179) 2020-03-19 21:51:26 +01:00
Devin Binnie
4f7782fb88 [MM-22494] Fixed misuse of config.set (#1191) 2020-02-14 15:21:09 -05:00
Devin Binnie
c895535449 [MM-22585] Ctrl/Cmd+<num> now switches to tabs based on order (#1193)
* [MM-22585] Ctrl/Cmd+<num> now switches to tabs based on order

* Added fix for hotkeying from SettingsPage
2020-02-14 13:45:06 -05:00
Devin Binnie
6551483db7 [MM-20796] Un-reverted the Ctrl+Tab fix and also made sure the tabs go in the right order (#1173)
* [MM-20796] Un-reverted the Ctrl+Tab fix and also made sure the tabs go in the right order

* Style fixes

* Update src/browser/components/MainPage.jsx

Co-Authored-By: Guillermo Vayá <guivaya@gmail.com>

* Different logic

Co-authored-by: Guillermo Vayá <guivaya@gmail.com>
2020-01-29 18:02:19 -05:00
Devin Binnie
81555eafba [MM-21341] Changed keyboard shortcut logic to pull focused web contents if an explicitly focused tab is not found (#1151) 2020-01-24 10:07:28 +01:00
Devin Binnie
31cc745748 [MM-19919] Allow links to other servers to go directly to that server in the app (#1165)
* [MM-19919] Allow links to other servers to go directly to that server in the app

* Added index to getSerrver() and used that for handling inter team links
2020-01-23 10:46:17 -05:00
Guillermo Vayá
33e24030d1 [MM-21192] allow for certificate selection (#1148)
* wip

* first working version

* kinda show the cert

* fix lint

* wip

* wip

* css fixes, cleanup

* fix lint

* get back to normal op

* get back cert name

* wip, added cert info screen

* queue cert requests, move user to cert request team

* certifications queued

* remove unneded import

* remove log

* remove commented code

* cleanup

* remove trust certificate dialog for showing it

* fix CR comments
2020-01-16 20:37:25 -05:00
Devin Binnie
5a237d8d88 [MM-20822] Added cut/paste/zoom events to other pages and added exceptions for dev tools and new server modal (#1133)
* [MM-20822] Added cut/paste/zoom events to other pages and added exceptions for dev tools and new server modal

* Using getFocusedWebContents

* Fixed an issue where the webcontents aren't found if you're on a login page

* Potential fix for mojave pasting on new team modal
2020-01-13 12:28:00 -05:00
Devin Binnie
932ddafdb0 [MM-10586] Desktop App Window/Tabs Update (#1056)
* [MM-19054] Added new server tab look and feel, still missing proper hover states and session expired icon

* [MM-19055] Added window controls and removed border for macOS

* [MM-19055] Add dark mode for macOS

* [MM-19054] Added session expired icon

* Test windows titlebar

* Fixed the menu issue and added non-macOS dark mode

* Blank commit

* Fixed a lint issue

* Fixed more lint issues

* Fixed more issues

* New tray icons

* [MM-19603] Drag and drop tabs

* Fixed some assets and fixed build output to include missing assets

* Fixed a couple small issues

* Only show tabs for only 1 server on Mac

* Fixed some more tests

* Fixed another test

* Revert "Fixed another test"

This reverts commit 36040294a71a68663d06996d71eecc5ed23d7014.

* Fixed another test

* Trial and error!

* A bunch of additional fixes

* Fixed a lint issue

* Fixed restore focus on add server tab causing bad UX

* Trial and error on flaky test again

* Fixed some bugs based on PR feedback.

* blank commit to push tests

* Revert "Test windows titlebar"

This reverts commit 9cd46b71b1427b75942434ac49185870d2437b85.

* Remove the rest of the old new titlebar and fixes

* Added three-dot link

* New menu

* Rest of new windows menu and other fixes

* Fixed lint errors

* Added windows 10 style title bar buttons for non mac OS

* Lint fixes and enabled the tab bar regardless of number of servers

* Missed one

* Fixed unicode characters

* Commenting out test that should no longer be applicable

* Removed Windows 10 style titlebar icons and used material design instead

* Fixed a lint issue

* Some small UX fixes

* blank commit

* Fixed an issue where dropping the first tab moves it too far over before snapping into place

* Additional style fixes

* Another small issue fix

* Back to Windows 10 style

* Lint fixes

* Accessible three dot menu

* Lint fixes

* Shrinking tabs when window is too small

* Gradient between tabs and title bar buttons when window is too small

* Add drag to gradient

* Replaced icons, drag and drop cursor sticking fix, slight tab change

* Lint and some mac fixes

* Light theme fix to three dot menu

* Hack for tab sticking to cursor on macOS

* Fixes for the find utility

* Fix for Catalina dark mode

* Revert "Fix for Catalina dark mode"

This reverts commit 45da05dd0f17f46efd1c53fafb92e9c1fd9dd8d9.

* Fixed a couple issues Dean found

* More fixes

* Three dot hover effect to circle

* PR feedback

* Test fixes

* Test and config fixes

* Disable dragging when there are GPO servers

* [MM-20757] Fixed dark mode on debug when running macOS Catalina

* Allow future config versions to use v2 config if launching this version of the app

* Oops

* New titlebar icons, blur for titlebar on inactive

* Lint fix

* Set unfocused opacity to 0.4

* Final FINAL icons

* Fixed closing menu not returning focus to the app

* Lint fix

* Update src/browser/components/TabBar.jsx

Co-Authored-By: Guillermo Vayá <guivaya@gmail.com>

* Update src/main/Validator.js

Co-Authored-By: Guillermo Vayá <guivaya@gmail.com>

* Lint fixes

* Moved react-smooth-dnd fork to MM org and fixed another merge issue

Co-authored-by: mattermod <mattermod@users.noreply.github.com>
Co-authored-by: Guillermo Vayá <guivaya@gmail.com>
2020-01-03 12:00:43 -05:00
Allen Lai
2a426ebe09 MM-18754: Desktop: Convert binding functions to arrow functions (#1123)
* change to using arrow function

* conform to lint
2019-12-30 11:08:27 +01:00
Dean Whillier
81c32c2d8c Manually handle misbehaving keyboard shortcuts (#1092)
* manually handle misbehaving keyboard shortcuts

MM-19198
MM-19032

includes zooming, redo/undo & copy/cut/paste for good measure

* manually handle misbehaving menu items

* bump electron minor version

* remove temp log import

* update context menu package version
2019-10-28 11:27:59 -04:00
Dean Whillier
e4044f533d re-focus renderer (#1064)
- using the menu hotkeys was causing the renderer to somehow loose focus, preventing further hotkeys from working
2019-10-11 09:17:51 -04:00
Devin Binnie
695d246a67 [MM-19187] Focus the webview on server selection (#1058) 2019-10-08 17:25:51 -04:00
Dean Whillier
761ef8d0e6 [MM-18152] Desktop notifications (#1040)
* temp

* add in html5 notification tests

* strip out custom permissions handling

* disable middle click

* validate as URI instead of URL

allow’s custom protocol’s to pass through

* add context isolation to new window requests

* add new permissions handling

* prevent setting user to away from quit/shutdown

* dispatch desktop notifications from renderer

* remove test code

* log desktop notification errors

* should deny as a last resort

* only trigger callback once
2019-09-23 14:59:12 -04:00
Dean Whillier
e12d47ea62 Mm 16694 master validate urls (#1000)
* validate urls before deeplink or link click

* tests for isValidURL utility function

* review change - invert condition

* add validation for loaded files

bounds-info.json, app-state.json, config.json

* further validation and tweaks

certificate.json, permission.json

* add 2 more files for validation

* parse and validate deeplinks

- includes fix for windows deeplink when app is open

* disable auto-updator when in dev

* Squirrel is not used anymore

* fix validating allowedProtocols

* discard any args following a deeplink url

* tweaks

* update test

* support scheme’s with and without slashes

* stop after finding the first occurance of a deep link

* test updates

* updates to run tests successfully

* port updates to validation from 4.2

* url validation updates

changed validation package to better support internal domains and punycode domains
2019-09-09 12:38:31 -04:00
Yuya Ochiai
6d6d586b3b Add eslint-plugin-eslint-comments 2019-03-12 23:31:45 +09:00
Romain Maneschi
1ef2108756 add a menu to open dev tools for current webview 2019-02-07 00:23:25 +01:00
Sven Huester
fa961654f3 fixes several typos 2018-12-02 14:55:24 +01:00
Jesse Hallam
cbe7889f20 MM-12275: detect an expired session and show badging 2018-09-24 18:26:45 -04:00
Yuya Ochiai
23ca8bbe5a Use ES6 class for React components 2018-09-03 23:43:09 +09:00
Yuya Ochiai
d73f98825e Apply no-var eslint rule 2018-09-03 21:41:04 +09:00
sudheer
579f99a800 Change to explicit close function for closing finder 2018-08-01 19:35:49 +05:30
sudheer
945918e6c0 Change toggle to always open for cntrl/cmd+F 2018-07-26 13:25:22 +05:30
sudheer
6baa034197 Fix review comments 2018-07-09 18:12:51 +05:30
sudheer
e95c8cc3c5 Add CTRL+F shortcut to work as browser search
* Add new finder for each webview contents
2018-07-06 12:21:06 +05:30
Yuya Ochiai
37b71476d2 Fix ESLint header/header error 2018-05-31 00:30:24 +09:00
Harrison Healey
846f05fac2 Revert "Merge pull request #745 from mattermost/mm9922"
This reverts commit b5ff04256b, reversing
changes made to 800f85bb1f.
2018-04-26 09:25:53 -04:00
Yuya Ochiai
60e6058869 Use ES6 import/export for modules 2018-04-10 22:00:30 +09:00
Harrison Healey
71dcec33a4 MM-9922 Fixed CSS transition when mousing onto internal link 2018-03-29 09:41:23 -04:00
Harrison Healey
d1b70863b5 MM-9922 Don't show hovered URL for internal links 2018-03-26 17:06:20 -04:00
Yuya Ochiai
e80aae20d0 Migrate to react-transition-group v2
https://github.com/reactjs/react-transition-group/blob/v2.2.1/Migration.md
2018-02-23 00:46:16 +09:00
Yuya Ochiai
197b172a59 Fix eslint errors 2018-02-23 00:37:24 +09:00
Jesse Hallam
620c5484e3 invoke yarn fix:js to adopt the updated eslint rules. No other changes are included. 2018-02-21 14:21:16 -05:00
Yuya Ochiai
08b1058694 Add PermissionRequestDialog for when the app doesn't show the TabBar 2017-11-08 01:37:39 +09:00