From f9b13e39fa3b1fd5b12a4c3ff8c3f06ac8a2553b Mon Sep 17 00:00:00 2001
From: Devin Binnie <52460000+devinbinnie@users.noreply.github.com>
Date: Mon, 12 May 2025 09:10:27 -0400
Subject: [PATCH] Fix tasbar/dock translations (#3410)

---
 i18n/en.json                                  |  6 ++--
 .../components/SettingsModal/definition.tsx   | 32 +++++++++++++------
 2 files changed, 26 insertions(+), 12 deletions(-)

diff --git a/i18n/en.json b/i18n/en.json
index 83dddc4c..7173a424 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -259,9 +259,11 @@
   "renderer.components.settingsPage.serverSetting.noServers": "No servers added",
   "renderer.components.settingsPage.serverSetting.noServers.description": "Add a server to connect to your team's communication hub",
   "renderer.components.settingsPage.serverSetting.title": "Servers",
-  "renderer.components.settingsPage.showUnreadBadge": "Show red badge on {taskbar} icon to indicate unread messages",
-  "renderer.components.settingsPage.showUnreadBadge.description": "Regardless of this setting, mentions are always indicated with a red badge and item count on the {taskbar} icon.",
+  "renderer.components.settingsPage.showUnreadBadge.description.dock": "Regardless of this setting, mentions are always indicated with a red badge and item count on the Dock icon.",
+  "renderer.components.settingsPage.showUnreadBadge.description.taskbar": "Regardless of this setting, mentions are always indicated with a red badge and item count on the taskbar icon.",
+  "renderer.components.settingsPage.showUnreadBadge.dock": "Show red badge on Dock icon to indicate unread messages",
   "renderer.components.settingsPage.showUnreadBadge.heading": "Unread Badge",
+  "renderer.components.settingsPage.showUnreadBadge.taskbar": "Show red badge on taskbar icon to indicate unread messages",
   "renderer.components.settingsPage.spellChecker": "Spell Checker",
   "renderer.components.settingsPage.spellCheckerSetting.language": "Spell Checker Languages",
   "renderer.components.settingsPage.startAppOnLogin": "Start app on login",
diff --git a/src/renderer/components/SettingsModal/definition.tsx b/src/renderer/components/SettingsModal/definition.tsx
index 187d3cf8..843653c9 100644
--- a/src/renderer/components/SettingsModal/definition.tsx
+++ b/src/renderer/components/SettingsModal/definition.tsx
@@ -212,18 +212,30 @@ const definition: (intl: IntlShape) => Promise<SettingsDefinition> = async (intl
                             />
                         ),
                         label: (
-                            <FormattedMessage
-                                id='renderer.components.settingsPage.showUnreadBadge'
-                                defaultMessage='Show red badge on {taskbar} icon to indicate unread messages'
-                                values={{taskbar: window.process.platform === 'win32' ? 'taskbar' : 'Dock'}}
-                            />
+                            window.process.platform === 'win32' ? (
+                                <FormattedMessage
+                                    id='renderer.components.settingsPage.showUnreadBadge.taskbar'
+                                    defaultMessage='Show red badge on taskbar icon to indicate unread messages'
+                                />
+                            ) : (
+                                <FormattedMessage
+                                    id='renderer.components.settingsPage.showUnreadBadge.dock'
+                                    defaultMessage='Show red badge on Dock icon to indicate unread messages'
+                                />
+                            )
                         ),
                         subLabel: (
-                            <FormattedMessage
-                                id='renderer.components.settingsPage.showUnreadBadge.description'
-                                defaultMessage='Regardless of this setting, mentions are always indicated with a red badge and item count on the {taskbar} icon.'
-                                values={{taskbar: window.process.platform === 'win32' ? 'taskbar' : 'Dock'}}
-                            />
+                            window.process.platform === 'win32' ? (
+                                <FormattedMessage
+                                    id='renderer.components.settingsPage.showUnreadBadge.description.taskbar'
+                                    defaultMessage='Regardless of this setting, mentions are always indicated with a red badge and item count on the taskbar icon.'
+                                />
+                            ) : (
+                                <FormattedMessage
+                                    id='renderer.components.settingsPage.showUnreadBadge.description.dock'
+                                    defaultMessage='Regardless of this setting, mentions are always indicated with a red badge and item count on the Dock icon.'
+                                />
+                            )
                         ),
                     },
                 },