phlux/mattermostest
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fixed issue with notification sounds not working correctly (#1818)

Browse Source
This commit is contained in:
Devin Binnie
2021-10-18 18:22:58 -04:00
committed by GitHub
parent 12052d4e0b
commit ebba86bc08
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/main/notifications/Mention.ts
View File

@@ -20,22 +20,22 @@ const defaultOptions = {
export const DEFAULT_WIN7 = 'Ding'; export const DEFAULT_WIN7 = 'Ding';
export class Mention extends Notification { export class Mention extends Notification {
customSound: boolean; customSound: string;
channel: {id: string}; // TODO: Channel from mattermost-redux channel: {id: string}; // TODO: Channel from mattermost-redux
teamId: string; teamId: string;
constructor(customOptions: MentionOptions, channel: {id: string}, teamId: string) { constructor(customOptions: MentionOptions, channel: {id: string}, teamId: string) {
super({...defaultOptions, ...customOptions});
const options = {...defaultOptions, ...customOptions}; const options = {...defaultOptions, ...customOptions};
if (process.platform === 'darwin') { if (process.platform === 'darwin') {
// Notification Center shows app's icon, so there were two icons on the notification. // Notification Center shows app's icon, so there were two icons on the notification.
Reflect.deleteProperty(options, 'icon'); Reflect.deleteProperty(options, 'icon');
} }
const isWin7 = (process.platform === 'win32' && osVersion.isLowerThanOrEqualWindows8_1() && DEFAULT_WIN7); const isWin7 = (process.platform === 'win32' && osVersion.isLowerThanOrEqualWindows8_1() && DEFAULT_WIN7);
const customSound = Boolean(!options.silent && ((options.data && options.data.soundName !== 'None' && options.data.soundName) || isWin7)); const customSound = String(!options.silent && ((options.data && options.data.soundName !== 'None' && options.data.soundName) || isWin7));
if (customSound) { if (customSound) {
options.silent = true; options.silent = true;
} }
super(options);
this.customSound = customSound; this.customSound = customSound;
this.channel = channel; this.channel = channel;