Various build and developer fixes, some optimizations (#2975)

* Various build and developer fixes, some optimizations

* Fix the linux build

* Fix afterpack

* Fix notarization variables

* Revert macos-notification-state changes from this PR

* Only build the tar for PRs

* Also ci

* Fix copy script

* Fix copy script more

* Remove @babel/cli

* Fix windows build

* Fix MAS build

.github/workflows/build-for-pr.yml

@@ -38,7 +38,7 @@ jobs:
       - name: ci/build
         run: |
           mkdir -p ./build/linux
-          npm run package:linux
+          npm run package:linux-tar
           bash -x ./scripts/patch_updater_yml.sh
           bash -x ./scripts/cp_artifacts.sh release ./build/linux
       - name: ci/upload-build
@@ -158,8 +158,8 @@ jobs:
           npm ci
       - name: ci/build
         env:
-          APPLEID: ${{ secrets.MM_DESKTOP_MAC_INSTALLER_APPLE_ID }}
-          APPLEIDPASS: ${{ secrets.MM_DESKTOP_MAC_INSTALLER_APPLE_ID_PASS }}
+          APPLE_ID: ${{ secrets.MM_DESKTOP_MAC_INSTALLER_APPLE_ID }}
+          APPLE_APP_SPECIFIC_PASSWORD: ${{ secrets.MM_DESKTOP_MAC_INSTALLER_APPLE_ID_PASS }}
           CSC_FOR_PULL_REQUEST: true
           CSC_KEY_PASSWORD: ${{ secrets.MM_DESKTOP_MAC_INSTALLER_CSC_KEY_PASSWORD }}
           CSC_LINK: ${{ secrets.MM_DESKTOP_MAC_INSTALLER_CSC_LINK }}

.github/workflows/ci.yaml

@@ -34,7 +34,7 @@ jobs:
       - name: ci/build
         run: |
           mkdir -p ./build/linux
-          npm run package:linux
+          npm run package:linux-tar
           bash -x ./scripts/patch_updater_yml.sh
           bash -x ./scripts/cp_artifacts.sh release ./build/linux
       - name: ci/upload-test-results

.github/workflows/nightly-main.yml

@@ -111,6 +111,7 @@ jobs:
   mac-app-store-preflight:
     runs-on: macos-12
     env:
+      MAC_PROFILE: ${{ secrets.MM_DESKTOP_MAC_INSTALLER_DMG_PROFILE }}
       MAS_PROFILE: ${{ secrets.MM_DESKTOP_MAC_APP_STORE_MAS_PROFILE }}
       MACOS_API_KEY_ID: ${{ secrets.MM_DESKTOP_MAC_APP_STORE_MACOS_API_KEY_ID }}
       MACOS_API_KEY: ${{ secrets.MM_DESKTOP_MAC_APP_STORE_MACOS_API_KEY }}
@@ -134,7 +135,9 @@ jobs:
           brew install yq
           npm ci
       - name: nightly/copy-provisioning-profile
-        run: echo $MAS_PROFILE | base64 -D > ./mas.provisionprofile
+        run: |
+          echo $MAC_PROFILE | base64 -D > ./mac.provisionprofile
+          echo $MAS_PROFILE | base64 -D > ./mas.provisionprofile
       - name: nightly/patch-version-number-for-MAS
         run: ./scripts/patch_mas_version.sh
       - name: nightly/test
@@ -167,8 +170,8 @@ jobs:
         uses: ./.github/actions/test
       - name: nightly/build
         env:
-          APPLEID: ${{ secrets.MM_DESKTOP_MAC_INSTALLER_APPLE_ID }}
-          APPLEIDPASS: ${{ secrets.MM_DESKTOP_MAC_INSTALLER_APPLE_ID_PASS }}
+          APPLE_ID: ${{ secrets.MM_DESKTOP_MAC_INSTALLER_APPLE_ID }}
+          APPLE_APP_SPECIFIC_PASSWORD: ${{ secrets.MM_DESKTOP_MAC_INSTALLER_APPLE_ID_PASS }}
           CSC_FOR_PULL_REQUEST: true
           CSC_KEY_PASSWORD: ${{ secrets.MM_DESKTOP_MAC_INSTALLER_CSC_KEY_PASSWORD }}
           CSC_LINK: ${{ secrets.MM_DESKTOP_MAC_INSTALLER_CSC_LINK }}

.github/workflows/nightly-rainforest.yml

@@ -97,8 +97,8 @@ jobs:
         uses: ./.github/actions/test
       - name: nightly/build
         env:
-          APPLEID: ${{ secrets.MM_DESKTOP_MAC_INSTALLER_APPLE_ID }}
-          APPLEIDPASS: ${{ secrets.MM_DESKTOP_MAC_INSTALLER_APPLE_ID_PASS }}
+          APPLE_ID: ${{ secrets.MM_DESKTOP_MAC_INSTALLER_APPLE_ID }}
+          APPLE_APP_SPECIFIC_PASSWORD: ${{ secrets.MM_DESKTOP_MAC_INSTALLER_APPLE_ID_PASS }}
           CSC_FOR_PULL_REQUEST: true
           CSC_KEY_PASSWORD: ${{ secrets.MM_DESKTOP_MAC_INSTALLER_CSC_KEY_PASSWORD }}
           CSC_LINK: ${{ secrets.MM_DESKTOP_MAC_INSTALLER_CSC_LINK }}

.github/workflows/release-mas.yaml

@@ -17,6 +17,7 @@ jobs:
   mac-app-store-preflight:
     runs-on: macos-12
     env:
+      MAC_PROFILE: ${{ secrets.MM_DESKTOP_MAC_INSTALLER_DMG_PROFILE }}
       MAS_PROFILE: ${{ secrets.MM_DESKTOP_MAC_APP_STORE_MAS_PROFILE }}
       MACOS_API_KEY_ID: ${{ secrets.MM_DESKTOP_MAC_APP_STORE_MACOS_API_KEY_ID }}
       MACOS_API_KEY: ${{ secrets.MM_DESKTOP_MAC_APP_STORE_MACOS_API_KEY }}
@@ -38,7 +39,9 @@ jobs:
           brew install yq
           npm ci
       - name: release/copy-provisioning-profile
-        run: echo $MAS_PROFILE | base64 -D > ./mas.provisionprofile
+        run: |
+          echo $MAC_PROFILE | base64 -D > ./mac.provisionprofile
+          echo $MAS_PROFILE | base64 -D > ./mas.provisionprofile
       - name: release/patch-version-number-for-MAS
         run: ./scripts/patch_mas_version.sh
       - name: release/test

.github/workflows/release.yaml

@@ -139,8 +139,8 @@ jobs:
         uses: ./.github/actions/test
       - name: release/build
         env:
-          APPLEID: ${{ secrets.MM_DESKTOP_MAC_INSTALLER_APPLE_ID }}
-          APPLEIDPASS: ${{ secrets.MM_DESKTOP_MAC_INSTALLER_APPLE_ID_PASS }}
+          APPLE_ID: ${{ secrets.MM_DESKTOP_MAC_INSTALLER_APPLE_ID }}
+          APPLE_APP_SPECIFIC_PASSWORD: ${{ secrets.MM_DESKTOP_MAC_INSTALLER_APPLE_ID_PASS }}
           CSC_FOR_PULL_REQUEST: true
           CSC_KEY_PASSWORD: ${{ secrets.MM_DESKTOP_MAC_INSTALLER_CSC_KEY_PASSWORD }}
           CSC_LINK: ${{ secrets.MM_DESKTOP_MAC_INSTALLER_CSC_LINK }}