phlux/mattermostest
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Improve codes to disable nodeIntegration

Browse Source
This commit is contained in:
Yuya Ochiai
2016-04-23 20:37:57 +09:00
parent c3761637d2
commit e051810ccc
1 changed files with 2 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/browser/index.jsx
View File

@@ -25,16 +25,6 @@ const settings = require('../common/settings');
remote.getCurrentWindow().removeAllListeners('focus'); remote.getCurrentWindow().removeAllListeners('focus');
// New window should disable nodeIntergration.
const originalWindowOpen = window.open;
window.open = function(url, name, features) {
var f = 'nodeIntegration=no';
if (features !== null) {
f += ',' + features;
}
originalWindowOpen(url, name, f);
};
var MainPage = React.createClass({ var MainPage = React.createClass({
getInitialState: function() { getInitialState: function() {
return { return {
@@ -283,7 +273,8 @@ var MattermostView = React.createClass({
var currentURL = url.parse(webview.getURL()); var currentURL = url.parse(webview.getURL());
var destURL = url.parse(e.url); var destURL = url.parse(e.url);
if (currentURL.host === destURL.host) { if (currentURL.host === destURL.host) {
window.open(e.url, 'Mattermost'); // New window should disable nodeIntergration.
window.open(e.url, 'Mattermost', 'nodeIntegration=no');
} else { } else {
// if the link is external, use default browser. // if the link is external, use default browser.
require('shell').openExternal(e.url); require('shell').openExternal(e.url);