phlux/mattermostest
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

[MM-40266] Refactor and tests for main/allowProtocolDialog (#1875)

Browse Source
This commit is contained in:
Devin Binnie
2021-11-26 09:54:13 -05:00
committed by GitHub
parent d0e1936b2c
commit d1eaed8b32
2 changed files with 238 additions and 65 deletions
Download Patch File Download Diff File Expand all files Collapse all files

135
src/main/allowProtocolDialog.ts
View File

@@ -16,76 +16,81 @@ import * as Validator from './Validator';
import {getMainWindow} from './windows/windowManager';
const allowedProtocolFile = path.resolve(app.getPath('userData'), 'allowedProtocols.json');
let allowedProtocols: string[] = [];
function addScheme(scheme: string) {
const proto = `${scheme}:`;
if (!allowedProtocols.includes(proto)) {
allowedProtocols.push(proto);
export class AllowProtocolDialog {
allowedProtocols: string[];
constructor() {
this.allowedProtocols = [];
}
}
function init() {
fs.readFile(allowedProtocolFile, 'utf-8', (err, data) => {
if (!err) {
allowedProtocols = JSON.parse(data);
allowedProtocols = Validator.validateAllowedProtocols(allowedProtocols) || [];
init = () => {
fs.readFile(allowedProtocolFile, 'utf-8', (err, data) => {
if (!err) {
this.allowedProtocols = JSON.parse(data);
this.allowedProtocols = Validator.validateAllowedProtocols(this.allowedProtocols) || [];
}
this.addScheme('http');
this.addScheme('https');
protocols.forEach((protocol) => {
if (protocol.schemes && protocol.schemes.length > 0) {
protocol.schemes.forEach(this.addScheme);
}
});
});
}
addScheme = (scheme: string) => {
const proto = `${scheme}:`;
if (!this.allowedProtocols.includes(proto)) {
this.allowedProtocols.push(proto);
}
addScheme('http');
addScheme('https');
protocols.forEach((protocol) => {
if (protocol.schemes && protocol.schemes.length > 0) {
protocol.schemes.forEach(addScheme);
}
handleDialogEvent = (protocol: string, URL: string) => {
if (this.allowedProtocols.indexOf(protocol) !== -1) {
shell.openExternal(URL);
return;
}
const mainWindow = getMainWindow();
if (!mainWindow) {
return;
}
dialog.showMessageBox(mainWindow, {
title: 'Non http(s) protocol',
message: `${protocol} link requires an external application.`,
detail: `The requested link is ${URL} . Do you want to continue?`,
defaultId: 2,
type: 'warning',
buttons: [
'Yes',
`Yes (Save ${protocol} as allowed)`,
'No',
],
cancelId: 2,
noLink: true,
}).then(({response}) => {
switch (response) {
case 1: {
this.allowedProtocols.push(protocol);
function handleError(err: NodeJS.ErrnoException | null) {
if (err) {
log.error(err);
}
}
fs.writeFile(allowedProtocolFile, JSON.stringify(this.allowedProtocols), handleError);
shell.openExternal(URL);
break;
}
case 0:
shell.openExternal(URL);
break;
default:
break;
}
});
});
}
}
function handleDialogEvent(protocol: string, URL: string) {
if (allowedProtocols.indexOf(protocol) !== -1) {
shell.openExternal(URL);
return;
}
const mainWindow = getMainWindow();
if (!mainWindow) {
return;
}
dialog.showMessageBox(mainWindow, {
title: 'Non http(s) protocol',
message: `${protocol} link requires an external application.`,
detail: `The requested link is ${URL} . Do you want to continue?`,
defaultId: 2,
type: 'warning',
buttons: [
'Yes',
`Yes (Save ${protocol} as allowed)`,
'No',
],
cancelId: 2,
noLink: true,
}).then(({response}) => {
switch (response) {
case 1: {
allowedProtocols.push(protocol);
function handleError(err: NodeJS.ErrnoException | null) {
if (err) {
log.error(err);
}
}
fs.writeFile(allowedProtocolFile, JSON.stringify(allowedProtocols), handleError);
shell.openExternal(URL);
break;
}
case 0:
shell.openExternal(URL);
break;
default:
break;
}
});
}
export default {
init,
handleDialogEvent,
};
const allowProtocolDialog = new AllowProtocolDialog();
export default allowProtocolDialog;