From d1e5505bd42180ff086cb4adf281ed1b0c99886d Mon Sep 17 00:00:00 2001 From: Devin Binnie <52460000+devinbinnie@users.noreply.github.com> Date: Wed, 6 Oct 2021 16:26:01 -0400 Subject: [PATCH] [MM-39139] Workaround for transparency issue for BrowserViews on Electron v14.1.0+ (#1792) --- src/main/views/modalView.ts | 5 +++++ src/main/views/teamDropdownView.ts | 5 +++++ src/main/views/viewManager.ts | 5 +++++ 3 files changed, 15 insertions(+) diff --git a/src/main/views/modalView.ts b/src/main/views/modalView.ts index 8f0a4375..5358a20e 100644 --- a/src/main/views/modalView.ts +++ b/src/main/views/modalView.ts @@ -35,6 +35,11 @@ export class ModalView { contextIsolation: process.env.NODE_ENV !== 'test', preload, nodeIntegration: process.env.NODE_ENV === 'test', + + // Workaround for this issue: https://github.com/electron/electron/issues/30993 + // eslint-disable-next-line @typescript-eslint/ban-ts-comment + // @ts-ignore + transparent: true, }}); this.onReject = onReject; this.onResolve = onResolve; diff --git a/src/main/views/teamDropdownView.ts b/src/main/views/teamDropdownView.ts index d1e1633d..024d50bd 100644 --- a/src/main/views/teamDropdownView.ts +++ b/src/main/views/teamDropdownView.ts @@ -49,6 +49,11 @@ export default class TeamDropdownView { contextIsolation: process.env.NODE_ENV !== 'test', preload, nodeIntegration: process.env.NODE_ENV === 'test', + + // Workaround for this issue: https://github.com/electron/electron/issues/30993 + // eslint-disable-next-line @typescript-eslint/ban-ts-comment + // @ts-ignore + transparent: true, }}); this.view.webContents.loadURL(getLocalURLString('dropdown.html')); diff --git a/src/main/views/viewManager.ts b/src/main/views/viewManager.ts index 525c192e..b27282e0 100644 --- a/src/main/views/viewManager.ts +++ b/src/main/views/viewManager.ts @@ -295,6 +295,11 @@ export class ViewManager { nativeWindowOpen: true, contextIsolation: process.env.NODE_ENV !== 'test', nodeIntegration: process.env.NODE_ENV === 'test', + + // Workaround for this issue: https://github.com/electron/electron/issues/30993 + // eslint-disable-next-line @typescript-eslint/ban-ts-comment + // @ts-ignore + transparent: true, }}); const query = new Map([['url', urlString]]); const localURL = getLocalURLString('urlView.html', query);