phlux/mattermostest
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix npm run build when using webpack 1.12.15

Browse Source 
'remote' module is used in electron-connect but it's removed from electron target on webpack 1.12.15.
So define 'remote' as "externals" to avoid bundling error.

http://webpack.github.io/docs/configuration.html#externals
This commit is contained in:
Yuya Ochiai
2016-04-13 23:34:50 +09:00
parent 0f89418fb0
commit cc2d65c741
2 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
gulpfile.js
View File

@@ -107,7 +107,7 @@ gulp.task('webpack:browser', function() {
__filename: false, __filename: false,
__dirname: false __dirname: false
}, },
target: 'electron' target: 'electron-renderer'
})) }))
.pipe(gulp.dest('dist/browser/')); .pipe(gulp.dest('dist/browser/'));
}); });
@@ -128,7 +128,10 @@ gulp.task('webpack:main', function() {
__filename: false, __filename: false,
__dirname: false __dirname: false
}, },
target: 'electron' target: 'electron-main',
externals: {
remote: true // for electron-connect
}
})) }))
.pipe(gulp.dest('dist/')); .pipe(gulp.dest('dist/'));
}); });

3
package.json
View File

@@ -30,7 +30,7 @@
"babel-preset-react": "^6.3.13", "babel-preset-react": "^6.3.13",
"chromedriver": "^2.20.0", "chromedriver": "^2.20.0",
"del": "^2.2.0", "del": "^2.2.0",
"electron-connect": "^0.3.3", "electron-connect": "^0.3.7",
"electron-packager": "^5.1.0", "electron-packager": "^5.1.0",
"electron-prebuilt": "0.36.11", "electron-prebuilt": "0.36.11",
"esformatter": "^0.8.1", "esformatter": "^0.8.1",
@@ -48,6 +48,7 @@
"through2": "^2.0.1", "through2": "^2.0.1",
"vinyl-named": "^1.1.0", "vinyl-named": "^1.1.0",
"webdriverio": "^3.3.0", "webdriverio": "^3.3.0",
"webpack": "^1.12.15",
"webpack-stream": "^3.1.0" "webpack-stream": "^3.1.0"
} }
} }