phlux/mattermostest
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Re-enable window.eval()

Browse Source 
Close #333
This commit is contained in:
Yuya Ochiai
2017-02-03 22:11:40 +09:00
parent d9d51821e6
commit ca5632342e
3 changed files with 1 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@@ -23,6 +23,7 @@ Release date: TBD
- Remove remaining badges after logging out of the team - Remove remaining badges after logging out of the team
- Fixed an issue where context menu appears many times after reloading - Fixed an issue where context menu appears many times after reloading
- Fixed an issue where minimum window size is not set - Fixed an issue where minimum window size is not set
- Fixed an issue where Google login form is not working
#### Windows #### Windows
- Fixed an issue where an unexpected window appears while install/uninstalling - Fixed an issue where an unexpected window appears while install/uninstalling

4
src/browser/webview/mattermost.js
View File

@@ -4,10 +4,6 @@ const electron = require('electron');
const ipc = electron.ipcRenderer; const ipc = electron.ipcRenderer;
const notification = require('../js/notification'); const notification = require('../js/notification');
window.eval = global.eval = () => {
throw new Error('Sorry, Mattermost does not support window.eval() for security reasons.');
};
Reflect.deleteProperty(global.Buffer); // http://electron.atom.io/docs/tutorial/security/#buffer-global Reflect.deleteProperty(global.Buffer); // http://electron.atom.io/docs/tutorial/security/#buffer-global
function hasClass(element, className) { function hasClass(element, className) {

2
test/specs/security_test.js
View File

@@ -99,8 +99,6 @@ describe('application', function desc() {
}; };
return Promise.all([ return Promise.all([
tryEval(0), tryEval(0),
tryEval(1),
tryEval(2),
tryEvalInSettingsPage() tryEvalInSettingsPage()
]); ]);
}); });