[MM-38524] Rework the closing and opening tab logic, fixed login issue (#1735)

* Rework the closing and opening tab logic to better suit adding and removing servers

* A couple more fixes

* Lint fix

* [MM-38524] Fix login issue

* Remove unneeded code

src/common/communication.ts

@@ -97,3 +97,4 @@ export const RECEIVE_DROPDOWN_MENU_SIZE = 'receive-dropdown-menu-size';
 export const SEND_DROPDOWN_MENU_SIZE = 'send-dropdown-menu-size';
 
 export const BROWSER_HISTORY_PUSH = 'browser-history-push';
+export const APP_LOGGED_IN = 'app-logged-in';

src/common/tabs/TabView.ts

@@ -30,17 +30,15 @@ export function getDefaultTeamWithTabsFromTeam(team: Team) {
             {
                 name: TAB_MESSAGING,
                 order: 0,
-                isClosed: false,
+                isOpen: true,
             },
             {
                 name: TAB_FOCALBOARD,
                 order: 1,
-                isClosed: false,
             },
             {
                 name: TAB_PLAYBOOKS,
                 order: 2,
-                isClosed: false,
             },
         ],
     };

src/common/utils/util.ts

@@ -37,7 +37,7 @@ function shorten(string: string, max?: number) {
     return string;
 }
 
-export function isServerVersionGreaterThanOrEqualTo(currentVersion: string, compareVersion: string): boolean {
+function isServerVersionGreaterThanOrEqualTo(currentVersion: string, compareVersion: string): boolean {
     if (currentVersion === compareVersion) {
         return true;
     }