phlux/mattermostest
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Fix flaky unit test (#2479)

Browse Source
This commit is contained in:
Devin Binnie
2022-12-16 17:18:16 -04:00
committed by GitHub
parent 7bbcbccbd3
commit a089d51d0e
1 changed files with 4 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/main/diagnostics/steps/internal/utils.test.js
View File

@@ -6,12 +6,6 @@ import config from 'common/config';
import {addDurationToFnReturnObject, boundsOk, browserWindowVisibilityStatus, checkPathPermissions, truncateString, webContentsCheck} from './utils'; import {addDurationToFnReturnObject, boundsOk, browserWindowVisibilityStatus, checkPathPermissions, truncateString, webContentsCheck} from './utils';
const sleep = (ms) => new Promise((resolve) => {
setTimeout(() => resolve(), ms);
});
const timeToSleep = 100;
jest.mock('fs', () => ({ jest.mock('fs', () => ({
promises: { promises: {
access: jest.fn(), access: jest.fn(),
@@ -26,13 +20,14 @@ jest.mock('common/config', () => ({
describe('main/diagnostics/utils', () => { describe('main/diagnostics/utils', () => {
describe('addDurationToFnReturnObject', () => { describe('addDurationToFnReturnObject', () => {
it('should measure the execution time of a function and include it in the response', async () => { it('should measure the execution time of a function and include it in the response', async () => {
const now = jest.spyOn(Date, 'now');
now.mockReturnValue(0);
const functionToMeasure = async () => { const functionToMeasure = async () => {
await sleep(timeToSleep); now.mockReturnValue(100);
}; };
const fn = addDurationToFnReturnObject(functionToMeasure); const fn = addDurationToFnReturnObject(functionToMeasure);
const b = await fn(); const b = await fn();
expect(b.duration).toBeGreaterThan(timeToSleep - 10); expect(b.duration).toBe(100);
expect(b.duration).toBeLessThan(timeToSleep * 1.5);
}); });
}); });