[MM-52696] Upgrade and clean up Desktop App dev dependencies (#2970)

* Upgrade to ESLint v8

* Upgrade TypeScript, api-types, react-intl

* Remove unnecessary dependencies

* Update to React 17.0.2

* npm audit fixes, remove storybook

* Lock some packages

* Remove nan patch

* Remove some deprecated dependencies

* Fix lint/type/tests

* Merge'd

* Fix bad use of spawn

* Fix notarize

* Fix afterpack, switch to tsc es2020

* Fix api types

* Use @mattermost/eslint-plugin

src/renderer/modals/permission/permissionModal.tsx

@@ -3,13 +3,14 @@
 
 import React from 'react';
 import {Modal, Button} from 'react-bootstrap';
-import {FormattedMessage, injectIntl, IntlShape} from 'react-intl';
+import type {IntlShape} from 'react-intl';
+import {FormattedMessage, injectIntl} from 'react-intl';
 
-import {PermissionModalInfo} from 'types/modals';
-
-import {t} from 'common/utils/util';
 import {PERMISSION_DESCRIPTION} from 'common/permissions';
 import {parseURL} from 'common/utils/url';
+import {t} from 'common/utils/util';
+
+import type {PermissionModalInfo} from 'types/modals';
 
 type Props = {
     handleDeny: React.MouseEventHandler<HTMLButtonElement>;
@@ -30,7 +31,7 @@ class PermissionModal extends React.PureComponent<Props, State> {
     getPermissionInfo = async () => {
         const {url, permission} = await this.props.getPermissionInfo();
         this.setState({url, permission});
-    }
+    };
 
     async componentDidMount() {
         await this.getPermissionInfo();