[MM-52696] Upgrade and clean up Desktop App dev dependencies (#2970)

* Upgrade to ESLint v8

* Upgrade TypeScript, api-types, react-intl

* Remove unnecessary dependencies

* Update to React 17.0.2

* npm audit fixes, remove storybook

* Lock some packages

* Remove nan patch

* Remove some deprecated dependencies

* Fix lint/type/tests

* Merge'd

* Fix bad use of spawn

* Fix notarize

* Fix afterpack, switch to tsc es2020

* Fix api types

* Use @mattermost/eslint-plugin

src/renderer/index.tsx

@@ -8,7 +8,7 @@ import 'renderer/css/index.css';
 import React from 'react';
 import ReactDOM from 'react-dom';
 
-import {CombinedConfig} from 'types/config';
+import type {CombinedConfig} from 'types/config';
 
 import MainPage from './components/MainPage';
 import IntlProvider from './intl_provider';
@@ -43,7 +43,7 @@ class Root extends React.PureComponent<Record<string, never>, State> {
     setInitialConfig = async () => {
         const config = await this.requestConfig(true);
         this.setState({config});
-    }
+    };
 
     reloadConfig = async () => {
         const config = await this.requestConfig();
@@ -68,7 +68,7 @@ class Root extends React.PureComponent<Record<string, never>, State> {
         if (window.process.platform !== 'darwin') {
             window.desktop.openAppMenu();
         }
-    }
+    };
 
     render() {
         const {config} = this.state;