[MM-52696] Upgrade and clean up Desktop App dev dependencies (#2970)

* Upgrade to ESLint v8

* Upgrade TypeScript, api-types, react-intl

* Remove unnecessary dependencies

* Update to React 17.0.2

* npm audit fixes, remove storybook

* Lock some packages

* Remove nan patch

* Remove some deprecated dependencies

* Fix lint/type/tests

* Merge'd

* Fix bad use of spawn

* Fix notarize

* Fix afterpack, switch to tsc es2020

* Fix api types

* Use @mattermost/eslint-plugin

src/common/appState.ts

@@ -4,8 +4,8 @@
 import {EventEmitter} from 'events';
 
 import {UPDATE_APPSTATE, UPDATE_APPSTATE_TOTALS, UPDATE_APPSTATE_FOR_VIEW_ID} from 'common/communication';
-import ServerManager from 'common/servers/serverManager';
 import {Logger} from 'common/log';
+import ServerManager from 'common/servers/serverManager';
 
 const log = new Logger('AppState');
 
@@ -27,7 +27,7 @@ export class AppState extends EventEmitter {
 
         this.expired.set(viewId, expired);
         this.emitStatusForView(viewId);
-    }
+    };
 
     updateMentions = (viewId: string, mentions: number) => {
         ServerManager.getViewLog(viewId, 'AppState').silly('updateMentions', mentions);
@@ -49,7 +49,7 @@ export class AppState extends EventEmitter {
         this.expired.delete(viewId);
         this.mentions.delete(viewId);
         this.unreads.delete(viewId);
-    }
+    };
 
     emitStatus = () => {
         log.silly('emitStatus');