[MM-52696] Upgrade and clean up Desktop App dev dependencies (#2970)

* Upgrade to ESLint v8

* Upgrade TypeScript, api-types, react-intl

* Remove unnecessary dependencies

* Update to React 17.0.2

* npm audit fixes, remove storybook

* Lock some packages

* Remove nan patch

* Remove some deprecated dependencies

* Fix lint/type/tests

* Merge'd

* Fix bad use of spawn

* Fix notarize

* Fix afterpack, switch to tsc es2020

* Fix api types

* Use @mattermost/eslint-plugin

e2e/modules/environment.js

@@ -4,18 +4,16 @@
 'use strict';
 
 const fs = require('fs');
-
 const path = require('path');
 
-const ps = require('ps-node');
-
-const {_electron: electron} = require('playwright');
 const chai = require('chai');
 const {ipcRenderer} = require('electron');
-
-const {SHOW_SETTINGS_WINDOW} = require('../../src/common/communication');
+const {_electron: electron} = require('playwright');
+const ps = require('ps-node');
 
 const {asyncSleep, mkDirAsync, rmDirAsync, unlinkAsync} = require('./utils');
+
+const {SHOW_SETTINGS_WINDOW} = require('../../src/common/communication');
 chai.should();
 
 const sourceRootDir = path.join(__dirname, '../..');

e2e/save_report.js

@@ -29,9 +29,10 @@
 
 const path = require('path');
 
-const chai = require('chai');
 const generator = require('mochawesome-report-generator');
 
+const {saveArtifacts} = require('./utils/artifacts');
+const {MOCHAWESOME_REPORT_DIR} = require('./utils/constants');
 const {
     generateShortSummary,
     generateTestReport,
@@ -40,8 +41,6 @@ const {
     readJsonFromFile,
     writeJsonToFile,
 } = require('./utils/report');
-const {saveArtifacts} = require('./utils/artifacts');
-const {MOCHAWESOME_REPORT_DIR} = require('./utils/constants');
 const {createTestCycle, createTestExecutions} = require('./utils/test_cases');
 
 require('dotenv').config();
@@ -51,7 +50,6 @@ const saveReport = async () => {
         BRANCH,
         BUILD_ID,
         BUILD_TAG,
-        FAILURE_MESSAGE,
         ZEPHYR_ENABLE,
         ZEPHYR_CYCLE_KEY,
         TYPE,

e2e/specs/focus.test.js

@@ -7,7 +7,6 @@ const fs = require('fs');
 const robot = require('robotjs');
 
 const {SHOW_SETTINGS_WINDOW} = require('../../src/common/communication');
-
 const env = require('../modules/environment');
 const {asyncSleep} = require('../modules/utils');
 

e2e/specs/menu_bar/history_menu.test.js

@@ -35,8 +35,10 @@ describe('history_menu', function desc() {
         const firstServer = this.serverMap[`${config.teams[0].name}___TAB_MESSAGING`].win;
         await env.loginToMattermost(firstServer);
         await firstServer.waitForSelector('#sidebarItem_off-topic');
+
         // click on Off topic channel
         await firstServer.click('#sidebarItem_off-topic');
+
         // click on town square channel
         await firstServer.click('#sidebarItem_town-square');
         await firstServer.locator('[aria-label="Back"]').click();

e2e/specs/settings.test.js

@@ -7,7 +7,6 @@
 const fs = require('fs');
 
 const {SHOW_SETTINGS_WINDOW} = require('../../src/common/communication');
-
 const env = require('../modules/environment');
 const {asyncSleep} = require('../modules/utils');
 

e2e/specs/settings/keyboard_shortcuts.test.js

@@ -8,7 +8,6 @@ const fs = require('fs');
 const robot = require('robotjs');
 
 const {SHOW_SETTINGS_WINDOW} = require('../../../src/common/communication');
-
 const env = require('../../modules/environment');
 const {asyncSleep} = require('../../modules/utils');
 

e2e/utils/artifacts.js

@@ -4,12 +4,11 @@
 /* eslint-disable no-console,consistent-return */
 
 const fs = require('fs');
-
 const path = require('path');
 
-const async = require('async');
-const {Upload} = require('@aws-sdk/lib-storage');
 const {S3} = require('@aws-sdk/client-s3');
+const {Upload} = require('@aws-sdk/lib-storage');
+const async = require('async');
 const mime = require('mime-types');
 const readdir = require('recursive-readdir');
 
@@ -29,7 +28,7 @@ const {
 const s3 = new S3({
     credentials: {
         accessKeyId: AWS_ACCESS_KEY_ID,
-        secretAccessKey: AWS_SECRET_ACCESS_KEY
+        secretAccessKey: AWS_SECRET_ACCESS_KEY,
     },
 });
 

e2e/utils/report.js

@@ -8,10 +8,10 @@ const os = require('os');
 const axios = require('axios');
 const fse = require('fs-extra');
 
-const package = require('../../package.json');
-
 const {MOCHAWESOME_REPORT_DIR} = require('./constants');
 
+const package = require('../../package.json');
+
 const MAX_FAILED_TITLES = 5;
 
 let incrementalDuration = 0;
@@ -116,11 +116,11 @@ function getOS() {
 
 function getEnvironmentValues() {
     return {
-        playwright_version: package.devDependencies.playwright,
-        electron_version: package.devDependencies.electron,
-        os_name: getOS(),
-        os_version: os.release(),
-        node_version: process.version,
+        playwrightVersion: package.devDependencies.playwright,
+        electronVersion: package.devDependencies.electron,
+        osName: getOS(),
+        osVersion: os.release(),
+        nodeVersion: process.version,
     };
 }
 
@@ -138,11 +138,11 @@ function generateTestReport(summary, isUploadedToS3, reportLink, testCycleKey) {
     } = process.env;
     const {statsFieldValue, stats} = summary;
     const {
-        playwright_version,
-        electron_version,
-        os_name,
-        os_version,
-        node_version,
+        playwrightVersion,
+        electronVersion,
+        osName,
+        osVersion,
+        nodeVersion,
     } = getEnvironmentValues();
 
     let testResult;
@@ -154,7 +154,7 @@ function generateTestReport(summary, isUploadedToS3, reportLink, testCycleKey) {
     }
 
     const title = generateTitle();
-    const envValue = `playwright@${playwright_version} | node@${node_version} | electron@${electron_version} | ${os_name}@${os_version}`;
+    const envValue = `playwright@${playwrightVersion} | node@${nodeVersion} | electron@${electronVersion} | ${osName}@${osVersion}`;
 
     if (FULL_REPORT === 'true') {
         let reportField;