phlux/mattermostest
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

[MM-32946][MM-40602] Ensure URL is valid before showing tooltip link, allow parsed URLs that aren't valid to open in browser (#1925)

Browse Source 
* [MM-40602] Ensure URL is valid before showing tooltip link

* Rework to allow invalid URLs to display

* [MM-32946] Allow parsable URLs and open invalid URIs in browser
This commit is contained in:
Devin Binnie
2021-12-16 10:06:11 -05:00
committed by GitHub
parent 5ef1f56d63
commit 9b1ee66c8c
5 changed files with 17 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/main/views/webContentEvents.test.js
View File

@@ -183,9 +183,10 @@ describe('main/views/webContentsEvents', () => {
expect(newWindow({url: 'devtools://aaaaaa.com'})).toStrictEqual({action: 'allow'});
});
it('should deny invalid URI', () => {
it('should open invalid URIs in browser', () => {
urlUtils.isValidURI.mockReturnValue(false);
expect(newWindow({url: 'http::'})).toStrictEqual({action: 'deny'});
expect(newWindow({url: 'https://google.com/?^'})).toStrictEqual({action: 'deny'});
expect(shell.openExternal).toBeCalledWith('https://google.com/?^');
});
it('should divert to allowProtocolDialog for custom protocols that are not mattermost or http', () => {