From 97a872a925488e6576be1f6da28f97728940726d Mon Sep 17 00:00:00 2001
From: Devin Binnie <52460000+devinbinnie@users.noreply.github.com>
Date: Wed, 23 Oct 2024 08:52:29 -0400
Subject: [PATCH] [MM-61058] Upgrade `electron-log`, turn on async logging
 (#3173)

---
 package-lock.json | 10 +++++-----
 package.json      |  2 +-
 src/common/log.ts |  4 ++++
 3 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/package-lock.json b/package-lock.json
index a1472073..f7e3dc4d 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -19,7 +19,7 @@
         "electron-context-menu": "3.6.1",
         "electron-extension-installer": "1.2.0",
         "electron-is-dev": "2.0.0",
-        "electron-log": "5.1.1",
+        "electron-log": "5.2.0",
         "electron-updater": "6.3.0",
         "joi": "17.12.2",
         "macos-notification-state": "3.0.0",
@@ -89,7 +89,7 @@
     },
     "api-types": {
       "name": "@mattermost/desktop-api",
-      "version": "5.10.0-1",
+      "version": "5.10.0-2",
       "dev": true,
       "license": "MIT",
       "peerDependencies": {
@@ -7488,9 +7488,9 @@
       }
     },
     "node_modules/electron-log": {
-      "version": "5.1.1",
-      "resolved": "https://registry.npmjs.org/electron-log/-/electron-log-5.1.1.tgz",
-      "integrity": "sha512-If7HU4Slbh2xfjOXOLxifkbgu6HmWDNJyXPLW+XNTOHMfFKisg0trA3d/7syyu25S+lHosfsd0VMfDSjGn1+Pw==",
+      "version": "5.2.0",
+      "resolved": "https://registry.npmjs.org/electron-log/-/electron-log-5.2.0.tgz",
+      "integrity": "sha512-VjLkvaLmbP3AOGOh5Fob9M8bFU0mmeSAb5G2EoTBx+kQLf2XA/0byzjsVGBTHhikbT+m1AB27NEQUv9wX9nM8w==",
       "engines": {
         "node": ">= 14"
       }
diff --git a/package.json b/package.json
index 49aa06e4..3f5de3ff 100644
--- a/package.json
+++ b/package.json
@@ -168,7 +168,7 @@
     "electron-context-menu": "3.6.1",
     "electron-extension-installer": "1.2.0",
     "electron-is-dev": "2.0.0",
-    "electron-log": "5.1.1",
+    "electron-log": "5.2.0",
     "electron-updater": "6.3.0",
     "joi": "17.12.2",
     "macos-notification-state": "3.0.0",
diff --git a/src/common/log.ts b/src/common/log.ts
index c81ee978..82d9e681 100644
--- a/src/common/log.ts
+++ b/src/common/log.ts
@@ -6,6 +6,10 @@ import log from 'electron-log';
 
 import Util from 'common/utils/util';
 
+// Turn off sync logging to prevent blocking the main thread
+// One downside to this is that some logs may not be written to the log file when the app closes
+log.transports.file.sync = false;
+
 export const setLoggingLevel = (level: string) => {
     if (log.transports.file.level === level) {
         return;