phlux/mattermostest
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

[MM-46857] Remove misleading console error about tab status when servers don't exist (#2260)

Browse Source
This commit is contained in:
Devin Binnie
2022-09-21 08:53:43 -04:00
committed by GitHub
parent 90123896b8
commit 7c3b68fb68
2 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
e2e/specs/settings.test.js
View File

@@ -5,7 +5,6 @@
'use strict'; 'use strict';
const fs = require('fs'); const fs = require('fs');
const path = require('path');
const {SHOW_SETTINGS_WINDOW} = require('../../src/common/communication'); const {SHOW_SETTINGS_WINDOW} = require('../../src/common/communication');

9
src/renderer/components/MainPage.tsx
View File

@@ -2,6 +2,8 @@
// Copyright (c) 2016-present Mattermost, Inc. All Rights Reserved. // Copyright (c) 2016-present Mattermost, Inc. All Rights Reserved.
// See LICENSE.txt for license information. // See LICENSE.txt for license information.
/* eslint-disable max-lines */
import classNames from 'classnames'; import classNames from 'classnames';
import React, {Fragment} from 'react'; import React, {Fragment} from 'react';
import {Container, Row} from 'react-bootstrap'; import {Container, Row} from 'react-bootstrap';
@@ -553,13 +555,14 @@ class MainPage extends React.PureComponent<Props, State> {
); );
const views = () => { const views = () => {
if (!this.props.teams.length) {
return null;
}
let component; let component;
const tabStatus = this.getTabViewStatus(); const tabStatus = this.getTabViewStatus();
if (!tabStatus) { if (!tabStatus) {
if (this.state.activeTabName) { if (this.state.activeTabName || this.state.activeServerName) {
console.error(`Not tabStatus for ${this.state.activeTabName}`); console.error(`Not tabStatus for ${this.state.activeTabName}`);
} else {
console.error('No tab status, tab doesn\'t exist anymore');
} }
return null; return null;
} }