[MM-40329] Unit tests for main/views (#1883)
* WIP * [MM-40329] Unit tests for main/views * Lint/type fix * Merge'd
This commit is contained in:
Devin Binnie
704
src/main/views/viewManager.test.js
Normal file
704
src/main/views/viewManager.test.js
Normal file
@@ -0,0 +1,704 @@
|
||||
// Copyright (c) 2016-present Mattermost, Inc. All Rights Reserved.
|
||||
// See LICENSE.txt for license information.
|
||||
|
||||
/* eslint-disable max-lines */
|
||||
'use strict';
|
||||
|
||||
import {dialog} from 'electron';
|
||||
|
||||
import {BROWSER_HISTORY_PUSH, LOAD_SUCCESS} from 'common/communication';
|
||||
import {MattermostServer} from 'common/servers/MattermostServer';
|
||||
import {getServerView, getTabViewName} from 'common/tabs/TabView';
|
||||
import urlUtils from 'common/utils/url';
|
||||
|
||||
import {MattermostView} from './MattermostView';
|
||||
import {ViewManager} from './viewManager';
|
||||
|
||||
jest.mock('electron', () => ({
|
||||
dialog: {
|
||||
showErrorBox: jest.fn(),
|
||||
},
|
||||
ipcMain: {
|
||||
emit: jest.fn(),
|
||||
},
|
||||
}));
|
||||
|
||||
jest.mock('electron-log', () => ({
|
||||
warn: jest.fn(),
|
||||
error: jest.fn(),
|
||||
}));
|
||||
|
||||
jest.mock('common/tabs/TabView', () => ({
|
||||
getServerView: jest.fn(),
|
||||
getTabViewName: jest.fn(),
|
||||
}));
|
||||
|
||||
jest.mock('common/servers/MattermostServer', () => ({
|
||||
MattermostServer: jest.fn(),
|
||||
}));
|
||||
|
||||
jest.mock('common/utils/url', () => ({
|
||||
parseURL: (url) => {
|
||||
try {
|
||||
return new URL(url);
|
||||
} catch (e) {
|
||||
return null;
|
||||
}
|
||||
},
|
||||
getView: jest.fn(),
|
||||
}));
|
||||
|
||||
jest.mock('main/server/serverInfo', () => ({
|
||||
ServerInfo: jest.fn(),
|
||||
}));
|
||||
|
||||
jest.mock('./MattermostView', () => ({
|
||||
MattermostView: jest.fn(),
|
||||
}));
|
||||
|
||||
jest.mock('./modalManager', () => ({
|
||||
showModal: jest.fn(),
|
||||
}));
|
||||
jest.mock('./webContentEvents', () => ({}));
|
||||
|
||||
describe('main/views/viewManager', () => {
|
||||
describe('loadView', () => {
|
||||
const viewManager = new ViewManager({}, {});
|
||||
const onceFn = jest.fn();
|
||||
const loadFn = jest.fn();
|
||||
|
||||
beforeEach(() => {
|
||||
viewManager.createLoadingScreen = jest.fn();
|
||||
viewManager.showByName = jest.fn();
|
||||
getServerView.mockImplementation((srv, tab) => ({name: `${srv.name}-${tab.name}`}));
|
||||
MattermostView.mockImplementation(() => ({
|
||||
on: jest.fn(),
|
||||
load: loadFn,
|
||||
once: onceFn,
|
||||
}));
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
jest.resetAllMocks();
|
||||
viewManager.loadingScreen = undefined;
|
||||
viewManager.closedViews = new Map();
|
||||
viewManager.views = new Map();
|
||||
});
|
||||
|
||||
it('should add closed tabs to closedViews', () => {
|
||||
viewManager.loadView({name: 'server1'}, {}, {name: 'tab1', isOpen: false});
|
||||
expect(viewManager.closedViews.has('server1-tab1')).toBe(true);
|
||||
});
|
||||
|
||||
it('should remove from remove from closedViews when the tab is open', () => {
|
||||
viewManager.closedViews.set('server1-tab1', {});
|
||||
expect(viewManager.closedViews.has('server1-tab1')).toBe(true);
|
||||
viewManager.loadView({name: 'server1'}, {}, {name: 'tab1', isOpen: true});
|
||||
expect(viewManager.closedViews.has('server1-tab1')).toBe(false);
|
||||
});
|
||||
|
||||
it('should add view to views map, add listeners and show the view', () => {
|
||||
viewManager.loadView({name: 'server1'}, {}, {name: 'tab1', isOpen: true}, 'http://server-1.com/subpath');
|
||||
expect(viewManager.views.has('server1-tab1')).toBe(true);
|
||||
expect(viewManager.createLoadingScreen).toHaveBeenCalled();
|
||||
expect(onceFn).toHaveBeenCalledWith(LOAD_SUCCESS, viewManager.activateView);
|
||||
expect(loadFn).toHaveBeenCalledWith('http://server-1.com/subpath');
|
||||
expect(viewManager.showByName).toHaveBeenCalledWith('server1-tab1');
|
||||
});
|
||||
});
|
||||
|
||||
describe('reloadViewIfNeeded', () => {
|
||||
const viewManager = new ViewManager({}, {});
|
||||
|
||||
afterEach(() => {
|
||||
jest.resetAllMocks();
|
||||
viewManager.views = new Map();
|
||||
});
|
||||
|
||||
it('should reload view when URL is not on subpath of original server URL', () => {
|
||||
const view = {
|
||||
load: jest.fn(),
|
||||
view: {
|
||||
webContents: {
|
||||
getURL: () => 'http://server-2.com/subpath',
|
||||
},
|
||||
},
|
||||
tab: {
|
||||
url: new URL('http://server-1.com/'),
|
||||
},
|
||||
};
|
||||
viewManager.views.set('view1', view);
|
||||
viewManager.reloadViewIfNeeded('view1');
|
||||
expect(view.load).toHaveBeenCalledWith(new URL('http://server-1.com/'));
|
||||
});
|
||||
|
||||
it('should not reload if URLs are matching', () => {
|
||||
const view = {
|
||||
load: jest.fn(),
|
||||
view: {
|
||||
webContents: {
|
||||
getURL: () => 'http://server-1.com/',
|
||||
},
|
||||
},
|
||||
tab: {
|
||||
url: new URL('http://server-1.com/'),
|
||||
},
|
||||
};
|
||||
viewManager.views.set('view1', view);
|
||||
viewManager.reloadViewIfNeeded('view1');
|
||||
expect(view.load).not.toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it('should not reload if URL is subpath of server URL', () => {
|
||||
const view = {
|
||||
load: jest.fn(),
|
||||
view: {
|
||||
webContents: {
|
||||
getURL: () => 'http://server-1.com/subpath',
|
||||
},
|
||||
},
|
||||
tab: {
|
||||
url: new URL('http://server-1.com/'),
|
||||
},
|
||||
};
|
||||
viewManager.views.set('view1', view);
|
||||
viewManager.reloadViewIfNeeded('view1');
|
||||
expect(view.load).not.toHaveBeenCalled();
|
||||
});
|
||||
});
|
||||
|
||||
describe('reloadConfiguration', () => {
|
||||
const viewManager = new ViewManager({}, {});
|
||||
|
||||
beforeEach(() => {
|
||||
viewManager.loadView = jest.fn();
|
||||
viewManager.showByName = jest.fn();
|
||||
viewManager.showInitial = jest.fn();
|
||||
getServerView.mockImplementation((srv, tab) => ({name: `${srv.name}-${tab.name}`, url: new URL(`http://${srv.name}.com`)}));
|
||||
MattermostServer.mockImplementation((name, url) => ({
|
||||
name,
|
||||
url: new URL(url),
|
||||
}));
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
jest.resetAllMocks();
|
||||
delete viewManager.loadingScreen;
|
||||
delete viewManager.currentView;
|
||||
viewManager.closedViews = new Map();
|
||||
viewManager.views = new Map();
|
||||
});
|
||||
|
||||
it('should recycle existing views', () => {
|
||||
const view = {
|
||||
name: 'server1-tab1',
|
||||
tab: {
|
||||
name: 'server1-tab1',
|
||||
url: new URL('http://server1.com'),
|
||||
},
|
||||
};
|
||||
viewManager.views.set('server1-tab1', view);
|
||||
viewManager.reloadConfiguration([
|
||||
{
|
||||
name: 'server1',
|
||||
url: 'http://server1.com',
|
||||
order: 1,
|
||||
tabs: [
|
||||
{
|
||||
name: 'tab1',
|
||||
isOpen: true,
|
||||
},
|
||||
],
|
||||
},
|
||||
]);
|
||||
expect(viewManager.views.get('server1-tab1')).toBe(view);
|
||||
expect(viewManager.loadView).not.toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it('should close tabs that arent open', () => {
|
||||
viewManager.reloadConfiguration([
|
||||
{
|
||||
name: 'server1',
|
||||
url: 'http://server1.com',
|
||||
order: 1,
|
||||
tabs: [
|
||||
{
|
||||
name: 'tab1',
|
||||
isOpen: false,
|
||||
},
|
||||
],
|
||||
},
|
||||
]);
|
||||
expect(viewManager.closedViews.has('server1-tab1')).toBe(true);
|
||||
});
|
||||
|
||||
it('should create new views for new tabs', () => {
|
||||
viewManager.reloadConfiguration([
|
||||
{
|
||||
name: 'server1',
|
||||
url: 'http://server1.com',
|
||||
order: 1,
|
||||
tabs: [
|
||||
{
|
||||
name: 'tab1',
|
||||
isOpen: true,
|
||||
},
|
||||
],
|
||||
},
|
||||
]);
|
||||
expect(viewManager.loadView).toHaveBeenCalledWith({
|
||||
name: 'server1',
|
||||
url: new URL('http://server1.com'),
|
||||
}, expect.any(Object), {
|
||||
name: 'tab1',
|
||||
isOpen: true,
|
||||
});
|
||||
});
|
||||
|
||||
it('should set focus to current view on reload', () => {
|
||||
const view = {
|
||||
name: 'server1-tab1',
|
||||
tab: {
|
||||
name: 'server1-tab1',
|
||||
url: new URL('http://server1.com'),
|
||||
},
|
||||
};
|
||||
viewManager.currentView = 'server1-tab1';
|
||||
viewManager.views.set('server1-tab1', view);
|
||||
viewManager.reloadConfiguration([
|
||||
{
|
||||
name: 'server1',
|
||||
url: 'http://server1.com',
|
||||
order: 1,
|
||||
tabs: [
|
||||
{
|
||||
name: 'tab1',
|
||||
isOpen: true,
|
||||
},
|
||||
],
|
||||
},
|
||||
]);
|
||||
expect(viewManager.showByName).toHaveBeenCalledWith('server1-tab1');
|
||||
});
|
||||
|
||||
it('should show initial if currentView has been removed', () => {
|
||||
const view = {
|
||||
name: 'server1-tab1',
|
||||
tab: {
|
||||
name: 'server1-tab1',
|
||||
url: new URL('http://server1.com'),
|
||||
},
|
||||
destroy: jest.fn(),
|
||||
};
|
||||
viewManager.currentView = 'server1-tab1';
|
||||
viewManager.views.set('server1-tab1', view);
|
||||
viewManager.reloadConfiguration([
|
||||
{
|
||||
name: 'server2',
|
||||
url: 'http://server2.com',
|
||||
order: 1,
|
||||
tabs: [
|
||||
{
|
||||
name: 'tab1',
|
||||
isOpen: true,
|
||||
},
|
||||
],
|
||||
},
|
||||
]);
|
||||
expect(viewManager.currentView).toBeUndefined();
|
||||
expect(viewManager.showInitial).toBeCalled();
|
||||
});
|
||||
|
||||
it('should remove unused views', () => {
|
||||
const view = {
|
||||
name: 'server1-tab1',
|
||||
tab: {
|
||||
name: 'server1-tab1',
|
||||
url: new URL('http://server1.com'),
|
||||
},
|
||||
destroy: jest.fn(),
|
||||
};
|
||||
viewManager.views.set('server1-tab1', view);
|
||||
viewManager.reloadConfiguration([
|
||||
{
|
||||
name: 'server2',
|
||||
url: 'http://server2.com',
|
||||
order: 1,
|
||||
tabs: [
|
||||
{
|
||||
name: 'tab1',
|
||||
isOpen: true,
|
||||
},
|
||||
],
|
||||
},
|
||||
]);
|
||||
expect(view.destroy).toBeCalled();
|
||||
expect(viewManager.showInitial).toBeCalled();
|
||||
});
|
||||
});
|
||||
|
||||
describe('showInitial', () => {
|
||||
const teams = [{
|
||||
name: 'server-1',
|
||||
order: 1,
|
||||
tabs: [
|
||||
{
|
||||
name: 'tab-1',
|
||||
order: 0,
|
||||
isOpen: false,
|
||||
},
|
||||
{
|
||||
name: 'tab-2',
|
||||
order: 2,
|
||||
isOpen: true,
|
||||
},
|
||||
{
|
||||
name: 'tab-3',
|
||||
order: 1,
|
||||
isOpen: true,
|
||||
},
|
||||
],
|
||||
}, {
|
||||
name: 'server-2',
|
||||
order: 0,
|
||||
tabs: [
|
||||
{
|
||||
name: 'tab-1',
|
||||
order: 0,
|
||||
isOpen: false,
|
||||
},
|
||||
{
|
||||
name: 'tab-2',
|
||||
order: 2,
|
||||
isOpen: true,
|
||||
},
|
||||
{
|
||||
name: 'tab-3',
|
||||
order: 1,
|
||||
isOpen: true,
|
||||
},
|
||||
],
|
||||
}];
|
||||
const viewManager = new ViewManager({teams}, {});
|
||||
|
||||
beforeEach(() => {
|
||||
viewManager.showByName = jest.fn();
|
||||
getTabViewName.mockImplementation((server, tab) => `${server}_${tab}`);
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
jest.resetAllMocks();
|
||||
viewManager.configServers = teams;
|
||||
delete viewManager.lastActiveServer;
|
||||
});
|
||||
|
||||
it('should show first server and first open tab in order when last active not defined', () => {
|
||||
viewManager.showInitial();
|
||||
expect(viewManager.showByName).toHaveBeenCalledWith('server-2_tab-3');
|
||||
});
|
||||
|
||||
it('should show first tab in order of last active server', () => {
|
||||
viewManager.lastActiveServer = 1;
|
||||
viewManager.showInitial();
|
||||
expect(viewManager.showByName).toHaveBeenCalledWith('server-1_tab-3');
|
||||
});
|
||||
|
||||
it('should show last active tab of first server', () => {
|
||||
viewManager.configServers = [{
|
||||
name: 'server-1',
|
||||
order: 1,
|
||||
tabs: [
|
||||
{
|
||||
name: 'tab-1',
|
||||
order: 0,
|
||||
isOpen: false,
|
||||
},
|
||||
{
|
||||
name: 'tab-2',
|
||||
order: 2,
|
||||
isOpen: true,
|
||||
},
|
||||
{
|
||||
name: 'tab-3',
|
||||
order: 1,
|
||||
isOpen: true,
|
||||
},
|
||||
],
|
||||
}, {
|
||||
name: 'server-2',
|
||||
order: 0,
|
||||
tabs: [
|
||||
{
|
||||
name: 'tab-1',
|
||||
order: 0,
|
||||
isOpen: false,
|
||||
},
|
||||
{
|
||||
name: 'tab-2',
|
||||
order: 2,
|
||||
isOpen: true,
|
||||
},
|
||||
{
|
||||
name: 'tab-3',
|
||||
order: 1,
|
||||
isOpen: true,
|
||||
},
|
||||
],
|
||||
lastActiveTab: 2,
|
||||
}];
|
||||
viewManager.showInitial();
|
||||
expect(viewManager.showByName).toHaveBeenCalledWith('server-2_tab-2');
|
||||
});
|
||||
|
||||
it('should show next tab when last active tab is closed', () => {
|
||||
viewManager.configServers = [{
|
||||
name: 'server-1',
|
||||
order: 1,
|
||||
tabs: [
|
||||
{
|
||||
name: 'tab-1',
|
||||
order: 0,
|
||||
isOpen: false,
|
||||
},
|
||||
{
|
||||
name: 'tab-2',
|
||||
order: 2,
|
||||
isOpen: true,
|
||||
},
|
||||
{
|
||||
name: 'tab-3',
|
||||
order: 1,
|
||||
isOpen: true,
|
||||
},
|
||||
],
|
||||
}, {
|
||||
name: 'server-2',
|
||||
order: 0,
|
||||
tabs: [
|
||||
{
|
||||
name: 'tab-1',
|
||||
order: 0,
|
||||
isOpen: true,
|
||||
},
|
||||
{
|
||||
name: 'tab-2',
|
||||
order: 2,
|
||||
isOpen: false,
|
||||
},
|
||||
{
|
||||
name: 'tab-3',
|
||||
order: 1,
|
||||
isOpen: true,
|
||||
},
|
||||
],
|
||||
lastActiveTab: 2,
|
||||
}];
|
||||
viewManager.showInitial();
|
||||
expect(viewManager.showByName).toHaveBeenCalledWith('server-2_tab-1');
|
||||
});
|
||||
});
|
||||
|
||||
describe('showByName', () => {
|
||||
const viewManager = new ViewManager({}, {});
|
||||
const baseView = {
|
||||
isReady: jest.fn(),
|
||||
show: jest.fn(),
|
||||
hide: jest.fn(),
|
||||
needsLoadingScreen: jest.fn(),
|
||||
window: {
|
||||
webContents: {
|
||||
send: jest.fn(),
|
||||
},
|
||||
},
|
||||
tab: {
|
||||
server: {
|
||||
name: 'server-1',
|
||||
},
|
||||
type: 'tab-1',
|
||||
},
|
||||
};
|
||||
|
||||
beforeEach(() => {
|
||||
viewManager.getCurrentView = jest.fn();
|
||||
viewManager.showLoadingScreen = jest.fn();
|
||||
viewManager.fadeLoadingScreen = jest.fn();
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
jest.resetAllMocks();
|
||||
viewManager.views = new Map();
|
||||
delete viewManager.currentView;
|
||||
});
|
||||
|
||||
it('should do nothing when view is already visible or if view doesnt exist', () => {
|
||||
const view = {
|
||||
...baseView,
|
||||
isVisible: true,
|
||||
};
|
||||
viewManager.views.set('server1-tab1', view);
|
||||
|
||||
viewManager.showByName('server1-tab1');
|
||||
expect(viewManager.currentView).toBeUndefined();
|
||||
expect(view.isReady).not.toBeCalled();
|
||||
expect(view.show).not.toBeCalled();
|
||||
|
||||
viewManager.showByName('some-view-name');
|
||||
expect(viewManager.currentView).toBeUndefined();
|
||||
expect(view.isReady).not.toBeCalled();
|
||||
expect(view.show).not.toBeCalled();
|
||||
});
|
||||
|
||||
it('should hide current view when new view is shown', () => {
|
||||
const oldView = {
|
||||
...baseView,
|
||||
isVisible: true,
|
||||
};
|
||||
const newView = {
|
||||
...baseView,
|
||||
isVisible: false,
|
||||
};
|
||||
viewManager.getCurrentView.mockImplementation(() => oldView);
|
||||
viewManager.views.set('oldView', oldView);
|
||||
viewManager.views.set('newView', newView);
|
||||
viewManager.currentView = 'oldView';
|
||||
viewManager.showByName('newView');
|
||||
expect(oldView.hide).toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it('should show loading screen when the view needs it', () => {
|
||||
const view = {...baseView};
|
||||
view.needsLoadingScreen.mockImplementation(() => true);
|
||||
viewManager.views.set('view1', view);
|
||||
viewManager.showByName('view1');
|
||||
expect(viewManager.showLoadingScreen).toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it('should show the view when ready', () => {
|
||||
const view = {...baseView};
|
||||
view.needsLoadingScreen.mockImplementation(() => false);
|
||||
view.isReady.mockImplementation(() => true);
|
||||
viewManager.views.set('view1', view);
|
||||
viewManager.showByName('view1');
|
||||
expect(viewManager.currentView).toBe('view1');
|
||||
expect(view.show).toHaveBeenCalled();
|
||||
expect(viewManager.fadeLoadingScreen).toHaveBeenCalled();
|
||||
});
|
||||
});
|
||||
|
||||
describe('showLoadingScreen', () => {
|
||||
const window = {
|
||||
getBrowserViews: jest.fn(),
|
||||
setTopBrowserView: jest.fn(),
|
||||
addBrowserView: jest.fn(),
|
||||
};
|
||||
const viewManager = new ViewManager({}, window);
|
||||
const loadingScreen = {webContents: {send: jest.fn()}};
|
||||
|
||||
beforeEach(() => {
|
||||
viewManager.createLoadingScreen = jest.fn();
|
||||
viewManager.setLoadingScreenBounds = jest.fn();
|
||||
window.getBrowserViews.mockImplementation(() => []);
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
jest.resetAllMocks();
|
||||
delete viewManager.loadingScreen;
|
||||
});
|
||||
|
||||
it('should create new loading screen if one doesnt exist and add it to the window', () => {
|
||||
viewManager.createLoadingScreen.mockImplementation(() => {
|
||||
viewManager.loadingScreen = loadingScreen;
|
||||
});
|
||||
viewManager.showLoadingScreen();
|
||||
expect(viewManager.createLoadingScreen).toHaveBeenCalled();
|
||||
expect(window.addBrowserView).toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it('should set the browser view as top if already exists and needs to be shown', () => {
|
||||
viewManager.loadingScreen = loadingScreen;
|
||||
window.getBrowserViews.mockImplementation(() => [loadingScreen]);
|
||||
viewManager.showLoadingScreen();
|
||||
expect(window.setTopBrowserView).toHaveBeenCalled();
|
||||
});
|
||||
});
|
||||
|
||||
describe('handleDeepLink', () => {
|
||||
const viewManager = new ViewManager({}, {});
|
||||
const baseView = {
|
||||
resetLoadingStatus: jest.fn(),
|
||||
load: jest.fn(),
|
||||
once: jest.fn(),
|
||||
isInitialized: jest.fn(),
|
||||
view: {
|
||||
webContents: {
|
||||
send: jest.fn(),
|
||||
},
|
||||
},
|
||||
serverInfo: {
|
||||
remoteInfo: {
|
||||
serverVersion: '1.0.0',
|
||||
},
|
||||
},
|
||||
};
|
||||
|
||||
beforeEach(() => {
|
||||
viewManager.openClosedTab = jest.fn();
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
jest.resetAllMocks();
|
||||
viewManager.views = new Map();
|
||||
viewManager.closedViews = new Map();
|
||||
});
|
||||
|
||||
it('should load URL into matching view', () => {
|
||||
urlUtils.getView.mockImplementation(() => ({name: 'view1', url: 'http://server-1.com/'}));
|
||||
const view = {...baseView};
|
||||
viewManager.views.set('view1', view);
|
||||
viewManager.handleDeepLink('mattermost://server-1.com/deep/link?thing=yes');
|
||||
expect(view.load).toHaveBeenCalledWith('http://server-1.com/deep/link?thing=yes');
|
||||
});
|
||||
|
||||
it('should send the URL to the view if its already loaded on a 6.0 server', () => {
|
||||
urlUtils.getView.mockImplementation(() => ({name: 'view1', url: 'http://server-1.com/'}));
|
||||
const view = {
|
||||
...baseView,
|
||||
serverInfo: {
|
||||
remoteInfo: {
|
||||
serverVersion: '6.0.0',
|
||||
},
|
||||
},
|
||||
tab: {
|
||||
server: {
|
||||
url: new URL('http://server-1.com'),
|
||||
},
|
||||
},
|
||||
};
|
||||
view.isInitialized.mockImplementation(() => true);
|
||||
viewManager.views.set('view1', view);
|
||||
viewManager.handleDeepLink('mattermost://server-1.com/deep/link?thing=yes');
|
||||
expect(view.view.webContents.send).toHaveBeenCalledWith(BROWSER_HISTORY_PUSH, '/deep/link?thing=yes');
|
||||
});
|
||||
|
||||
it('should throw error if view is missing', () => {
|
||||
urlUtils.getView.mockImplementation(() => ({name: 'view1', url: 'http://server-1.com/'}));
|
||||
const view = {...baseView};
|
||||
viewManager.handleDeepLink('mattermost://server-1.com/deep/link?thing=yes');
|
||||
expect(view.load).not.toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it('should throw dialog when cannot find the view', () => {
|
||||
const view = {...baseView};
|
||||
viewManager.handleDeepLink('mattermost://server-1.com/deep/link?thing=yes');
|
||||
expect(view.load).not.toHaveBeenCalled();
|
||||
expect(dialog.showErrorBox).toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it('should reopen closed tab if called upon', () => {
|
||||
urlUtils.getView.mockImplementation(() => ({name: 'view1', url: 'https://server-1.com/'}));
|
||||
viewManager.closedViews.set('view1', {});
|
||||
viewManager.handleDeepLink('mattermost://server-1.com/deep/link?thing=yes');
|
||||
expect(viewManager.openClosedTab).toHaveBeenCalledWith('view1', 'https://server-1.com/deep/link?thing=yes');
|
||||
});
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user