[MM-61717] Refresh Settings Modal without Bootstrap (#3337)

* [MM-61717] Refresh Settings Modal without Bootstrap

* Fix i18n

* Couple small bug fixes

* E2E test updates

* Fix linux tests

* PR feedback

* PR feedback

* PR feedback

* Fix the border opacity and height

* PR feedback

* PR feedback 2
This commit is contained in:
Devin Binnie
2025-02-27 15:51:49 -05:00
committed by GitHub
parent a4019ddd72
commit 5d7374971c
40 changed files with 2294 additions and 1669 deletions

View File

@@ -29,9 +29,10 @@ describe('settings/keyboard_shortcuts', function desc() {
settingsWindow = await this.app.waitForEvent('window', {
predicate: (window) => window.url().includes('settings'),
});
await settingsWindow.waitForSelector('.settingsPage.container');
await settingsWindow.waitForSelector('#settingCategoryButton-language');
await settingsWindow.click('#settingCategoryButton-language');
const textbox = await settingsWindow.waitForSelector('#inputSpellCheckerLocalesDropdown');
const textbox = await settingsWindow.waitForSelector('#selectSetting_spellCheckerLocales');
await textbox.scrollIntoViewIfNeeded();
});
@@ -45,22 +46,22 @@ describe('settings/keyboard_shortcuts', function desc() {
describe('MM-T1288 Manipulating Text', () => {
it('MM-T1288_1 should be able to select and deselect language in the settings window', async () => {
let textboxString;
await settingsWindow.click('#inputSpellCheckerLocalesDropdown');
await settingsWindow.type('#inputSpellCheckerLocalesDropdown', 'Afrikaans');
await settingsWindow.click('#selectSetting_spellCheckerLocales');
await settingsWindow.type('#selectSetting_spellCheckerLocales', 'Afrikaans');
robot.keyTap('tab');
await settingsWindow.isVisible('#appOptionsSaveIndicator');
await settingsWindow.isVisible('.SettingsModal__saving');
textboxString = await settingsWindow.innerText('div.SettingsPage__spellCheckerLocalesDropdown__multi-value__label');
textboxString = await settingsWindow.innerText('.SpellCheckerSetting .SelectSetting__select__multi-value__label');
textboxString.should.equal('Afrikaans');
await settingsWindow.isVisible('#appOptionsSaveIndicator');
await settingsWindow.isVisible('.SettingsModal__saving');
await settingsWindow.click('[aria-label="Remove Afrikaans"]');
await settingsWindow.isVisible('#appOptionsSaveIndicator');
await settingsWindow.isVisible('.SettingsModal__saving');
textboxString = await settingsWindow.inputValue('#inputSpellCheckerLocalesDropdown');
textboxString = await settingsWindow.inputValue('#selectSetting_spellCheckerLocales');
textboxString.should.equal('');
});
@@ -68,7 +69,7 @@ describe('settings/keyboard_shortcuts', function desc() {
const textToCopy = 'Afrikaans';
env.clipboard(textToCopy);
const textbox = await settingsWindow.waitForSelector('#inputSpellCheckerLocalesDropdown');
const textbox = await settingsWindow.waitForSelector('#selectSetting_spellCheckerLocales');
await textbox.selectText({force: true});
robot.keyTap('x', [env.cmdOrCtrl]);
@@ -85,7 +86,7 @@ describe('settings/keyboard_shortcuts', function desc() {
const textToCopy = 'Afrikaans';
env.clipboard(textToCopy);
const textbox = await settingsWindow.waitForSelector('#inputSpellCheckerLocalesDropdown');
const textbox = await settingsWindow.waitForSelector('#selectSetting_spellCheckerLocales');
await textbox.selectText({force: true});
robot.keyTap('c', [env.cmdOrCtrl]);