From 4428596809f39d47c1f4a23141fa4ceaa7c74b41 Mon Sep 17 00:00:00 2001
From: Devin Binnie <52460000+devinbinnie@users.noreply.github.com>
Date: Thu, 15 Jun 2023 16:40:52 -0400
Subject: [PATCH] [MM-53201] Fix piping concurrency issues with release post
 generation script (#2752)

---
 scripts/generate_release_post.sh | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/scripts/generate_release_post.sh b/scripts/generate_release_post.sh
index 4710105a..e5984e77 100755
--- a/scripts/generate_release_post.sh
+++ b/scripts/generate_release_post.sh
@@ -2,12 +2,18 @@
 set -eu
 
 VERSION="$1" # such as 5.3.0-rc.1, 5.0.0
-LAST_VERSION="$(git for-each-ref --sort=creatordate --format '%(refname)' refs/tags | grep "v[0-9]\.[0-9]\.[0-9]" | grep -v mas | grep -v "v$VERSION" | tail -1 | sed "s/refs\/tags\/v//")"
+
+TEMP_VERSION_FILE="$(mktemp -t temp_version_file.XXXX)"
+git for-each-ref --sort=creatordate --format '%(refname)' refs/tags | grep "v[0-9]\.[0-9]\.[0-9]" | grep -v mas | grep -v "v$VERSION" | sed "s/refs\/tags\/v//" > $TEMP_VERSION_FILE
+LAST_VERSION="$(cat $TEMP_VERSION_FILE | tail -1)"
+
+TEMP_CHANGES_FILE="$(mktemp -t temp_changes_file.XXXX)"
+git cherry -v v$LAST_VERSION v$VERSION | grep ^+ | grep "(#[0-9]\+)" > $TEMP_CHANGES_FILE
 
 cat <<-MD
 ### [v$VERSION](https://github.com/mattermost/desktop/releases/tag/v$VERSION) :tada:
 Changes:
-$(git cherry -v v$LAST_VERSION v$VERSION | grep ^+ | grep "(#[0-9]\+)" | sed "s/^+\s[a-zA-Z0-9]\+\s/- /" | sed "s/\s(#\([0-9]\+\))$/ [(#\1)](https:\/\/github.com\/mattermost\/desktop\/pull\/\1)/" | sed "s/\[\?MM-\([0-9]\+\)\]\?/[[MM-\1]](https:\/\/mattermost.atlassian.net\/browse\/MM-\1)/")
+$(cat $TEMP_CHANGES_FILE | sed "s/^+\s[a-zA-Z0-9]\+\s/- /" | sed "s/\s(#\([0-9]\+\))$/ [(#\1)](https:\/\/github.com\/mattermost\/desktop\/pull\/\1)/" | sed "s/\[\?MM-\([0-9]\+\)\]\?/[[MM-\1]](https:\/\/mattermost.atlassian.net\/browse\/MM-\1)/")
 
 The release will be available on GitHub shortly.
 MD