phlux/mattermostest
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

[MM-38433] Error checking when a bad server URL is entered (#1728)

Browse Source 
* [MM-38433] Error checking when a bad server URL is entered

* Add proper error handler call
This commit is contained in:
Devin Binnie
2021-09-10 11:08:38 -04:00
committed by GitHub
parent 082c95b094
commit 4019177fd1
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/main/server/serverAPI.ts
View File

@@ -37,8 +37,14 @@ export async function getServerAPI<T>(url: URL, isAuthenticated: boolean, onSucc
if (response.statusCode === 200) { if (response.statusCode === 200) {
response.on('data', (chunk: Buffer) => { response.on('data', (chunk: Buffer) => {
const raw = `${chunk}`; const raw = `${chunk}`;
const data = JSON.parse(raw) as T; try {
onSuccess(data); const data = JSON.parse(raw) as T;
onSuccess(data);
} catch (e) {
const error = `Error parsing server data from ${url.toString()}`;
log.error(error);
onError?.(new Error(error));
}
}); });
} else { } else {
onError?.(new Error(`Bad status code requesting from ${url.toString()}`)); onError?.(new Error(`Bad status code requesting from ${url.toString()}`));