MM-51956 - Fix for: Calls popout generating duplicate notifications (#2713)

* set userAgent in the widget popout

* tests

* set userAgent on widget, for consistency

* added link to ticket for the proper fix
This commit is contained in:
Christopher Poile
2023-05-11 13:54:20 -04:00
committed by GitHub
parent 925b2fcc32
commit 3b8bddd5e7
2 changed files with 39 additions and 3 deletions

View File

@@ -66,6 +66,7 @@ jest.mock('../utils', () => ({
openScreensharePermissionsSettingsMacOS: jest.fn(),
resetScreensharePermissionsMacOS: jest.fn(),
getLocalPreload: jest.fn(),
composeUserAgent: jest.fn(),
}));
describe('main/windows/callsWidgetWindow', () => {
@@ -401,6 +402,7 @@ describe('main/windows/callsWidgetWindow', () => {
it('onPopOutCreate - should attach correct listeners and should prevent redirects', () => {
let redirectListener;
let closedListener;
let frameFinishedLoadListener;
const popOut = {
on: (event, listener) => {
closedListener = listener;
@@ -409,8 +411,13 @@ describe('main/windows/callsWidgetWindow', () => {
on: (event, listener) => {
redirectListener = listener;
},
once: (event, listener) => {
frameFinishedLoadListener = listener;
},
id: 'webContentsId',
getURL: () => ('http://myurl.com'),
},
loadURL: jest.fn(),
};
const callsWidgetWindow = new CallsWidgetWindow();
@@ -418,11 +425,15 @@ describe('main/windows/callsWidgetWindow', () => {
expect(callsWidgetWindow.popOut).toBe(popOut);
expect(WebContentsEventManager.addWebContentsEventListeners).toHaveBeenCalledWith(popOut.webContents);
expect(redirectListener).toBeDefined();
expect(frameFinishedLoadListener).toBeDefined();
const event = {preventDefault: jest.fn()};
redirectListener(event);
expect(event.preventDefault).toHaveBeenCalled();
frameFinishedLoadListener();
expect(callsWidgetWindow.popOut.loadURL).toHaveBeenCalledTimes(1);
closedListener();
expect(callsWidgetWindow.popOut).not.toBeDefined();
});