[MM-60605] Fix the Download button being hidden on Windows/Linux (#3148)

* [MM-60605] Fix missing downloads/developer mode icon hidden on Linux and Windows

* Disable for mac

* Fix lint

* Fix misalignment on Windows

* "fix" linux

* Return to inline version, ignore Linux
This commit is contained in:
Devin Binnie
2024-09-23 08:41:40 -04:00
committed by GitHub
parent b4eeabb366
commit 3b179c7ec2
3 changed files with 49 additions and 61 deletions

View File

@@ -483,16 +483,17 @@ class MainPage extends React.PureComponent<Props, State> {
developerMode={this.state.developerMode} developerMode={this.state.developerMode}
/> />
{downloadsDropdownButton} {downloadsDropdownButton}
{window.process.platform !== 'darwin' && this.state.fullScreen && {window.process.platform !== 'darwin' && this.state.fullScreen && (
<span className='title-bar-btns'> <div
<div className={`button full-screen-button${this.props.darkMode ? ' darkMode' : ''}`}
className='button full-screen-button' onClick={this.handleExitFullScreen}
onClick={this.handleExitFullScreen} >
> <i className='icon icon-arrow-collapse'/>
<i className='icon icon-arrow-collapse'/> </div>
</div> )}
</span> {window.process.platform !== 'darwin' && !this.state.fullScreen && (
} <span style={{width: `${window.innerWidth - (window.navigator.windowControlsOverlay?.getTitlebarAreaRect().width ?? 0)}px`}}/>
)}
</div> </div>
</Row> </Row>
); );

View File

@@ -113,10 +113,6 @@ body {
color: rgba(243,243,243,0.7); color: rgba(243,243,243,0.7);
} }
.topBar.darkMode .title-bar-btns {
color: rgba(243,243,243,0.7);
}
.topBar .app-title { .topBar .app-title {
position: absolute; position: absolute;
top: 0; top: 0;
@@ -139,58 +135,43 @@ body {
color: rgba(221,221,221,0.64); color: rgba(221,221,221,0.64);
} }
.topBar .title-bar-btns { .full-screen-button {
position: relative;
line-height: 40px;
height: 40px;
z-index: 9;
color: rgba(61,60,64,0.7);
-webkit-app-region: no-drag;
display: grid;
grid-template-columns: repeat(3, 46px);
}
.topBar .title-bar-btns>.button {
grid-row: 1 / span 1;
display: flex;
justify-content: center;
align-items: center; align-items: center;
width: 100%; background: transparent;
height: 100%; border-radius: 4px;
user-select: none; border: none;
} cursor: pointer;
display: flex;
flex-direction: column;
justify-content: center;
margin: 4px;
position: relative;
width: 32px;
.topBar.darkMode .title-bar-btns>.button:hover { i {
background: rgba(255,255,255,0.1); color: rgba(63, 67, 80, 0.56);
} cursor: pointer;
font-size: 21px;
line-height: 21px;
}
.topBar.darkMode .title-bar-btns>.button:active { &:hover, &:focus {
background: rgba(255,255,255,0.2); i {
} color: rgba(63, 67, 80, 0.78);
}
}
.topBar .title-bar-btns>.button:hover { &.darkMode {
background: rgba(0,0,0,0.1); i {
} color: rgba(221, 223, 228, 0.56);
}
.topBar .title-bar-btns>.button:active { &:hover, &:focus {
background: rgba(0,0,0,0.2); i {
} color: rgba(221, 223, 228, 0.78);
}
.topBar .title-bar-btns>.full-screen-button { }
font-size: 18px; }
}
.topBar .title-bar-btns img {
opacity: 0.7;
}
.topBar.darkMode .title-bar-btns img {
filter: invert(100%);
-webkit-filter: invert(100%);
}
.topBar .title-bar-btns>.close-button, .topBar .title-bar-btns>.full-screen-button {
grid-column: 3;
} }
.topBar .overlay-gradient { .topBar .overlay-gradient {

View File

@@ -155,4 +155,10 @@ declare global {
}; };
}; };
} }
interface Navigator {
windowControlsOverlay?: {
getTitlebarAreaRect: () => DOMRect;
};
}
} }