[MM-19963] set working directory on start (#1105)

* [MM-19963] set current working directory for the app

* prevent failing if env variables are not setup

* [MM-19963] cwd if not in dev mode and only if necessary, log it if it happens

* fix remove path if no cert is present

* address CR suggestions

scripts/Makefile.ps1

@@ -439,7 +439,7 @@ function Get-Cert {
 }
 
 function Remove-Cert {
-    if (Test-Path $env:PFX) {
+    if (Test-Path 'env:PFX') {
         Print-Info "Removing windows certificate"
         Remove-Item -path "./mattermost-desktop-windows.pfx"
     }

scripts/notarize.js

@@ -14,7 +14,10 @@ exports.default = async function notarizing(context) {
   }
 
   const appName = context.packager.appInfo.productFilename;
-
+  if (typeof process.env.APPLEID === 'undefined') {
+    console.log('skipping notarization, remember to setup environment variables for APPLEID and APPLEIDPASS if you want to notarize');
+    return;
+  }
   await notarize({
 
     // should we change it to appBundleId: 'com.mattermost.desktop',

src/main.js

@@ -89,7 +89,6 @@ const customLogins = {};
  */
 async function initialize() {
   process.on('uncaughtException', criticalErrorHandler.processUncaughtExceptionHandler.bind(criticalErrorHandler));
-
   global.willAppQuit = false;
 
   // initialization that can run before the app is ready
@@ -167,6 +166,13 @@ function initializeAppEventListeners() {
 function initializeBeforeAppReady() {
   certificateStore = CertificateStore.load(path.resolve(app.getPath('userData'), 'certificate.json'));
 
+  // prevent using a different working directory, which happens on windows running after installation.
+  const expectedPath = path.dirname(process.execPath);
+  if (process.cwd() !== expectedPath && !isDev) {
+    console.warn(`Current working directory is ${process.cwd()}, changing into ${expectedPath}`);
+    process.chdir(expectedPath);
+  }
+
   // can only call this before the app is ready
   if (config.enableHardwareAcceleration === false) {
     app.disableHardwareAcceleration();