phlux/mattermostest
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

[MM-16516] Add a "don't trust" option for certificates (#1733)

Browse Source 
* Added checkbox to certificate not trusted modal

* Added functionality to store a dontTrust boolean with the certificate store
This commit is contained in:
John Willis
2021-09-14 05:16:04 -04:00
committed by GitHub
parent 20ec525819
commit 375da5bdb3
3 changed files with 26 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/main/certificateStore.ts
View File

@@ -13,10 +13,11 @@ import urlUtils from 'common/utils/url';
import * as Validator from './Validator';
function comparableCertificate(certificate: Certificate): ComparableCertificate {
function comparableCertificate(certificate: Certificate, dontTrust = false): ComparableCertificate {
return {
data: certificate.data.toString(),
issuerName: certificate.issuerName,
dontTrust,
};
}
@@ -53,8 +54,8 @@ export default class CertificateStore {
fs.writeFileSync(this.storeFile, JSON.stringify(this.data, null, ' '));
};
add = (targetURL: string, certificate: Certificate) => {
this.data[urlUtils.getHost(targetURL)] = comparableCertificate(certificate);
add = (targetURL: string, certificate: Certificate, dontTrust = false) => {
this.data[urlUtils.getHost(targetURL)] = comparableCertificate(certificate, dontTrust);
};
isExisting = (targetURL: string) => {
@@ -68,4 +69,12 @@ export default class CertificateStore {
}
return areEqual(this.data[host], comparableCertificate(certificate));
};
isExplicitlyUntrusted = (targetURL: string) => {
// Whether or not the certificate was explicitly marked as untrusted by
// clicking "Don't ask again" checkbox before cancelling the connection.
const host = urlUtils.getHost(targetURL);
const dontTrust = this.data[host]?.dontTrust;
return dontTrust === undefined ? false : dontTrust;
}
}