Merge pull request #187 from Razzeee/improve-menus

Improve menus due to improvements in electron

package.json

@@ -39,7 +39,7 @@
     "electron-builder": "5.2.1",
     "electron-connect": "^0.3.7",
     "electron-packager": "^7.0.1",
-    "electron-prebuilt": "1.2.6",
+    "electron-prebuilt": "1.2.7",
     "electron-winstaller": "^2.2.0",
     "esformatter": "^0.9.3",
     "esformatter-jsx": "^5.0.0",

src/browser/menus/context.js

@@ -7,19 +7,15 @@ const MenuItem = remote.MenuItem;
 var createDefault = function() {
   var menu = new Menu();
   menu.append(new MenuItem({
-    label: 'Cut',
     role: 'cut'
   }));
   menu.append(new MenuItem({
-    label: 'Copy',
     role: 'copy'
   }));
   menu.append(new MenuItem({
-    label: 'Paste',
     role: 'paste'
   }));
   menu.append(new MenuItem({
-    label: 'Select All',
     role: 'selectall'
   }));
   return menu;

src/main.js

@@ -163,6 +163,10 @@ app.on('activate', function(event) {
 });
 
 app.on('before-quit', function() {
+  // Make sure tray icon gets removed if the user exits via CTRL-Q
+  if (process.platform === 'win32') {
+    trayIcon.destroy();
+  }
   willAppQuit = true;
 });
 

src/main/menus/app.js

@@ -28,22 +28,13 @@ var createTemplate = function(mainWindow, config) {
       mainWindow.loadURL('file://' + __dirname + '/browser/settings.html');
     }
   }, separatorItem, {
-    label: 'Hide ' + app_name,
+    role: 'hide'
-    accelerator: 'Command+H',
-    selector: 'hide:'
   }, {
-    label: 'Hide Others',
+    role: 'hideothers'
-    accelerator: 'Command+Shift+H',
-    selector: 'hideOtherApplications:'
   }, {
-    label: 'Show All',
+    role: 'unhide'
-    selector: 'unhideAllApplications:'
   }, separatorItem, {
-    label: 'Quit ' + app_name,
+    role: 'quit'
-    accelerator: 'CmdOrCtrl+Q',
-    click: function(item, focusedWindow) {
-      electron.app.quit();
-    }
   }] : [{
     label: 'Settings',
     accelerator: 'CmdOrCtrl+,',
@@ -51,7 +42,7 @@ var createTemplate = function(mainWindow, config) {
       mainWindow.loadURL('file://' + __dirname + '/browser/settings.html');
     }
   }, separatorItem, {
-    label: 'Quit',
+    role: 'quit',
     accelerator: 'CmdOrCtrl+Q',
     click: function(item, focusedWindow) {
       electron.app.quit();
@@ -67,28 +58,16 @@ var createTemplate = function(mainWindow, config) {
   template.push({
     label: '&Edit',
     submenu: [{
-      label: 'Undo',
-      accelerator: 'CmdOrCtrl+Z',
       role: 'undo'
     }, {
-      label: 'Redo',
-      accelerator: 'Shift+CmdOrCtrl+Z',
       role: 'redo'
     }, separatorItem, {
-      label: 'Cut',
-      accelerator: 'CmdOrCtrl+X',
       role: 'cut'
     }, {
-      label: 'Copy',
-      accelerator: 'CmdOrCtrl+C',
       role: 'copy'
     }, {
-      label: 'Paste',
-      accelerator: 'CmdOrCtrl+V',
       role: 'paste'
     }, {
-      label: 'Select All',
-      accelerator: 'CmdOrCtrl+A',
       role: 'selectall'
     }, ]
   });
@@ -123,20 +102,7 @@ var createTemplate = function(mainWindow, config) {
         }
       }
     }, {
-      label: 'Toggle Full Screen',
+      role: 'togglefullscreen'
-      accelerator: (function() {
-        if (process.platform === 'darwin') {
-          return 'Ctrl+Command+F';
-        }
-        else {
-          return 'F11';
-        }
-      })(),
-      click: function(item, focusedWindow) {
-        if (focusedWindow) {
-          focusedWindow.setFullScreen(!focusedWindow.isFullScreen());
-        }
-      }
     }, separatorItem, {
       label: 'Actual Size',
       accelerator: 'CmdOrCtrl+0',
@@ -176,21 +142,9 @@ var createTemplate = function(mainWindow, config) {
   const window_menu = {
     label: '&Window',
     submenu: [{
-      label: 'Minimize',
+      role: 'minimize'
-      accelerator: 'CmdOrCtrl+M',
-      click: function(item, focusedWindow) {
-        if (focusedWindow) {
-          focusedWindow.minimize();
-        }
-      }
     }, {
-      label: 'Close',
+      role: 'close'
-      accelerator: 'CmdOrCtrl+W',
-      click: function(item, focusedWindow) {
-        if (focusedWindow) {
-          focusedWindow.close();
-        }
-      }
     }, separatorItem, ...config.teams.slice(0, 9).map((team, i) => {
       return {
         label: team.name,

src/main/menus/tray.js

@@ -25,10 +25,7 @@ function createTemplate(mainWindow, config) {
     }), {
       type: 'separator'
     }, {
-      label: 'Quit',
+      role: 'quit'
-      click: function(item) {
-        app.quit();
-      }
     }
   ];
   return template;