[MM-64399] Fix crash in electron-context-menu (#3441)

This commit is contained in:
Devin Binnie
2025-05-28 09:50:23 -04:00
committed by GitHub
parent 6be4083250
commit 200edf4f7d

View File

@@ -47,7 +47,7 @@ index 468e48b..e182878 100644
event: ElectronEvent event: ElectronEvent
) => MenuItemConstructorOptions[]; ) => MenuItemConstructorOptions[];
diff --git a/node_modules/electron-context-menu/index.js b/node_modules/electron-context-menu/index.js diff --git a/node_modules/electron-context-menu/index.js b/node_modules/electron-context-menu/index.js
index b10daea..d7d26f3 100644 index b10daea..4514ef1 100644
--- a/node_modules/electron-context-menu/index.js --- a/node_modules/electron-context-menu/index.js
+++ b/node_modules/electron-context-menu/index.js +++ b/node_modules/electron-context-menu/index.js
@@ -1,7 +1,6 @@ @@ -1,7 +1,6 @@
@@ -63,7 +63,7 @@ index b10daea..d7d26f3 100644
click(menuItem) { click(menuItem) {
properties.srcURL = menuItem.transform ? menuItem.transform(properties.srcURL) : properties.srcURL; properties.srcURL = menuItem.transform ? menuItem.transform(properties.srcURL) : properties.srcURL;
- download(win, properties.srcURL); - download(win, properties.srcURL);
+ win.webContents.downloadURL(properties.srcURL); + webContents(win).downloadURL(properties.srcURL);
}, },
}), }),
saveImageAs: decorateMenuItem({ saveImageAs: decorateMenuItem({
@@ -72,7 +72,7 @@ index b10daea..d7d26f3 100644
click(menuItem) { click(menuItem) {
properties.srcURL = menuItem.transform ? menuItem.transform(properties.srcURL) : properties.srcURL; properties.srcURL = menuItem.transform ? menuItem.transform(properties.srcURL) : properties.srcURL;
- download(win, properties.srcURL, {saveAs: true}); - download(win, properties.srcURL, {saveAs: true});
+ win.webContents.downloadURL(properties.srcURL, {saveAs: true}); + webContents(win).downloadURL(properties.srcURL, {saveAs: true});
}, },
}), }),
saveVideo: decorateMenuItem({ saveVideo: decorateMenuItem({
@@ -81,7 +81,7 @@ index b10daea..d7d26f3 100644
click(menuItem) { click(menuItem) {
properties.srcURL = menuItem.transform ? menuItem.transform(properties.srcURL) : properties.srcURL; properties.srcURL = menuItem.transform ? menuItem.transform(properties.srcURL) : properties.srcURL;
- download(win, properties.srcURL); - download(win, properties.srcURL);
+ win.webContents.downloadURL(properties.srcURL); + webContents(win).downloadURL(properties.srcURL);
}, },
}), }),
saveVideoAs: decorateMenuItem({ saveVideoAs: decorateMenuItem({
@@ -90,7 +90,7 @@ index b10daea..d7d26f3 100644
click(menuItem) { click(menuItem) {
properties.srcURL = menuItem.transform ? menuItem.transform(properties.srcURL) : properties.srcURL; properties.srcURL = menuItem.transform ? menuItem.transform(properties.srcURL) : properties.srcURL;
- download(win, properties.srcURL, {saveAs: true}); - download(win, properties.srcURL, {saveAs: true});
+ win.webContents.downloadURL(properties.srcURL, {saveAs: true}); + webContents(win).downloadURL(properties.srcURL, {saveAs: true});
}, },
}), }),
copyLink: decorateMenuItem({ copyLink: decorateMenuItem({
@@ -99,7 +99,7 @@ index b10daea..d7d26f3 100644
click(menuItem) { click(menuItem) {
properties.linkURL = menuItem.transform ? menuItem.transform(properties.linkURL) : properties.linkURL; properties.linkURL = menuItem.transform ? menuItem.transform(properties.linkURL) : properties.linkURL;
- download(win, properties.linkURL, {saveAs: true}); - download(win, properties.linkURL, {saveAs: true});
+ win.webContents.downloadURL(properties.linkURL, {saveAs: true}); + webContents(win).downloadURL(properties.linkURL, {saveAs: true});
}, },
}), }),
copyImage: decorateMenuItem({ copyImage: decorateMenuItem({