phlux/mattermostest
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

#1960 fix unexpected top menu focus (#1963)

Browse Source 
* #1960 fix unexpected top menu focus

* #1960 test update

* #1960 improved test

* #1960 optimized algrithm to handle only Alt key to improve performance and avoid side effects

* #1960 tests update

* #1960 fixed 3 dit menu focus on workspace change with Alt+1, Alt+2

* #313 fix linter issue

* #1960 fix linter issue

* tests update
This commit is contained in:
Profesor08
2022-02-08 06:23:51 -08:00
committed by GitHub
parent 301ba8deb2
commit 1c71579bbe
3 changed files with 47 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
src/main/views/MattermostView.test.js
View File

@@ -56,7 +56,8 @@ const tabView = new MessagingTabView(server);
describe('main/views/MattermostView', () => {
describe('load', () => {
const mattermostView = new MattermostView(tabView, {}, {}, {});
const window = {on: jest.fn()};
const mattermostView = new MattermostView(tabView, {}, window, {});
beforeEach(() => {
mattermostView.loadSuccess = jest.fn();
@@ -102,7 +103,8 @@ describe('main/views/MattermostView', () => {
});
describe('retry', () => {
const mattermostView = new MattermostView(tabView, {}, {}, {});
const window = {on: jest.fn()};
const mattermostView = new MattermostView(tabView, {}, window, {});
beforeEach(() => {
mattermostView.view.webContents.loadURL.mockImplementation(() => Promise.resolve());
@@ -153,7 +155,8 @@ describe('main/views/MattermostView', () => {
});
describe('loadSuccess', () => {
const mattermostView = new MattermostView(tabView, {}, {}, {});
const window = {on: jest.fn()};
const mattermostView = new MattermostView(tabView, {}, window, {});
beforeEach(() => {
jest.useFakeTimers();
@@ -173,7 +176,7 @@ describe('main/views/MattermostView', () => {
});
describe('show', () => {
const window = {addBrowserView: jest.fn(), removeBrowserView: jest.fn()};
const window = {addBrowserView: jest.fn(), removeBrowserView: jest.fn(), on: jest.fn()};
const mattermostView = new MattermostView(tabView, {}, window, {});
beforeEach(() => {
@@ -218,7 +221,7 @@ describe('main/views/MattermostView', () => {
});
describe('destroy', () => {
const window = {removeBrowserView: jest.fn()};
const window = {removeBrowserView: jest.fn(), on: jest.fn()};
const mattermostView = new MattermostView(tabView, {}, window, {});
beforeEach(() => {
@@ -245,10 +248,11 @@ describe('main/views/MattermostView', () => {
});
describe('handleInputEvents', () => {
const mattermostView = new MattermostView(tabView, {}, {}, {});
const window = {on: jest.fn()};
const mattermostView = new MattermostView(tabView, {}, window, {});
it('should open three dot menu on pressing Alt', () => {
mattermostView.handleInputEvents(null, {key: 'Alt', type: 'keyDown'});
mattermostView.handleInputEvents(null, {key: 'Alt', type: 'keyDown', alt: true, shift: false, control: false, meta: false});
mattermostView.handleInputEvents(null, {key: 'Alt', type: 'keyUp'});
expect(WindowManager.focusThreeDotMenu).toHaveBeenCalled();
});
@@ -268,7 +272,8 @@ describe('main/views/MattermostView', () => {
});
describe('handleDidNavigate', () => {
const mattermostView = new MattermostView(tabView, {}, {}, {});
const window = {on: jest.fn()};
const mattermostView = new MattermostView(tabView, {}, window, {});
beforeEach(() => {
mattermostView.setBounds = jest.fn();
@@ -286,7 +291,8 @@ describe('main/views/MattermostView', () => {
});
describe('handleUpdateTarget', () => {
const mattermostView = new MattermostView(tabView, {}, {}, {});
const window = {on: jest.fn()};
const mattermostView = new MattermostView(tabView, {}, window, {});
beforeEach(() => {
mattermostView.emit = jest.fn();
@@ -310,7 +316,8 @@ describe('main/views/MattermostView', () => {
});
describe('updateMentionsFromTitle', () => {
const mattermostView = new MattermostView(tabView, {}, {}, {});
const window = {on: jest.fn()};
const mattermostView = new MattermostView(tabView, {}, window, {});
it('should parse mentions from title', () => {
mattermostView.updateMentionsFromTitle('(7) Mattermost');