Clean up appState module, move to common, simplify events (#2676)

* Refactor appState into class, simplify events

* Move appState to common module, make case for object consistent

* Naming change

* Update name
This commit is contained in:
Devin Binnie
2023-04-14 12:09:33 -04:00
committed by GitHub
parent c0dddd88ee
commit 1428ba694b
13 changed files with 132 additions and 156 deletions

View File

@@ -3,6 +3,7 @@
import {BrowserView, dialog, ipcMain, IpcMainEvent, IpcMainInvokeEvent} from 'electron';
import AppState from 'common/appState';
import {SECOND, TAB_BAR_HEIGHT} from 'common/utils/constants';
import {
UPDATE_TARGET_URL,
@@ -23,6 +24,7 @@ import {
UNREAD_RESULT,
HISTORY,
GET_VIEW_INFO_FOR_TEST,
SESSION_EXPIRED,
} from 'common/communication';
import Config from 'common/config';
import {Logger} from 'common/log';
@@ -35,7 +37,6 @@ import {TabView, TAB_MESSAGING} from 'common/tabs/TabView';
import {localizeMessage} from 'main/i18nManager';
import MainWindow from 'main/windows/mainWindow';
import * as appState from '../appState';
import {getLocalURLString, getLocalPreload} from '../utils';
import {MattermostView} from './MattermostView';
@@ -66,6 +67,7 @@ export class ViewManager {
ipcMain.on(APP_LOGGED_OUT, this.handleAppLoggedOut);
ipcMain.on(RELOAD_CURRENT_VIEW, this.handleReloadCurrentView);
ipcMain.on(UNREAD_RESULT, this.handleFaviconIsUnread);
ipcMain.on(SESSION_EXPIRED, this.handleSessionExpired);
ServerManager.on(SERVERS_UPDATE, this.handleReloadConfiguration);
}
@@ -521,7 +523,13 @@ export class ViewManager {
private handleFaviconIsUnread = (e: Event, favicon: string, viewId: string, result: boolean) => {
log.silly('handleFaviconIsUnread', {favicon, viewId, result});
appState.updateUnreads(viewId, result);
AppState.updateUnreads(viewId, result);
}
private handleSessionExpired = (event: IpcMainEvent, isExpired: boolean, viewId: string) => {
ServerManager.getViewLog(viewId, 'ViewManager').debug('handleSessionExpired', isExpired);
AppState.updateExpired(viewId, isExpired);
}
/**