[MM-22239] Downloads dropdown (#2227)
* WIP: show/hide temp downloads dropdown * WIP: Position downloads dropdown correctly under the button * WIP: Use correct width for dropdown so that right radius and shadows are displayed * WIP: Add items to download list after finished downloading * WIP: Add download item base components * Add "clear all" functionality * Use type Record<> for downloads saved in config * Add styling to files in the downloads dropdown * Open file in folder when clicking it from downloads dropdown. Center svg in parent element * Update scrollbar styling * Update scrollbar styling * Update state of downloaded items if deleted from folder * Add progress bar in downloads * Use "x-uncompressed-content-length" in file downloads. * Keep downloads open when clicking outside their browserview * Use correct color for downloads dropdown button * Add better styling to downloads dropdown button * Allow only 50 download files maximum. Oldest file is being removed if reached * Autoclose downloads dropdown after 4s of download finish * Add file thumbnails * Dont show second dialog if first dismissed * Add red badge when downloads running and dropdown closed * Add menu item for Downloads * Add support for more code file extensions * Open downloads dropdown instead of folder from the menu * Run lint:js and fix problems * Add tests for utils * Fix issue with dropdown not displaying * Remove unecessary comment * Move downloads to separate json file, outside Config * Add downloads dropdown menu for the 3-dot button * Dont show dev tools for downloads * Add cancel download functionality * Add dark mode styling * Use View state for downloadsMenu open state * Fix some style issues * Add image preview for downloaded images * Remove extra devTool in weback config * Fix issue with paths on windows * Align items left in downloads menu * Use pretty-bytes for file sizes * Show download remaining time * Close downloads dropdown when clicking outside * Show different units in received bytes when they are different from the total units (kb/mb) * Dont hide downloads when mattermost view is clicked * Keep downloads open if download button is clicked * Use closest() to check for download clicks * Fix unit tests. Add tests for new Views and downloadManager Add @types/jest as devDependency for intellisense * Remove unecessary tsconfig for jest * Fix types error * Add all critical tests for downloadsManager * WIP: add e2e tests for downloads * WIP: add e2e tests for downloads * Rename downloads spec file * WIP: make vscode debugger work for e2e tests * Remove unused mock * Remove defaults for v4 config * Use electron-mocha for e2e debugger * Fix e2e tests spawning JsonFileManager twice * Add async fs functions and add tests for download item UI * Add async fs functions and add tests for download item UI * Improve tests with "waitForSelector" to wait for visible elements * Wait for page load before assertions * Add tests for file uploads/downloads * Dont show native notification for completed downloads if dropdown is open * Increment filenames if file already exists * Fix antializing in downloads dropdown * Fix styling of downloads header * Increase dimensions of green/red icons in downloads * Fix styling of 3-dot button * Fix unit tests * Show 3-dot button only on hover or click * PR review fixes * Revert vscode debug fixes * Mock fs.constants * Mock fs instead of JsonFileManager in downlaods tests * Mock fs instead of JsonFileManager in downlaods tests * Add necessary mocks for downloads manager * Mark file as deleted if user deleted it * Fix min-height of downloads dropdown and 3-dot icon position * Add more tests * Make size of downloads dropdown dynamic based on content * Combine log statements * Close 3-dot menu if user clicks elsewhere * Move application updates inside downloads dropdown * Fix update issues * Fix ipc event payload * Add missing prop * Remove unused translations * Fix failing test * Fix version unknown * Remove commented out component
This commit is contained in:
Tasos Boulis
@@ -2,7 +2,6 @@
|
||||
// See LICENSE.txt for license information.
|
||||
|
||||
'use strict';
|
||||
|
||||
import {BACK_BAR_HEIGHT, TAB_BAR_HEIGHT} from 'common/utils/constants';
|
||||
import {runMode} from 'common/utils/util';
|
||||
|
||||
@@ -28,6 +27,14 @@ jest.mock('path', () => {
|
||||
resolve: (basePath, ...restOfPath) => original.join('/path/to/app/src/main', ...restOfPath),
|
||||
};
|
||||
});
|
||||
jest.mock('fs', () => ({
|
||||
accessSync: jest.fn().mockImplementation(() => {
|
||||
throw new Error('file missing');
|
||||
}).mockImplementationOnce(() => {}),
|
||||
constants: {
|
||||
F_OK: 0,
|
||||
},
|
||||
}));
|
||||
|
||||
describe('main/utils', () => {
|
||||
describe('shouldBeHiddenOnStartup', () => {
|
||||
@@ -107,4 +114,52 @@ describe('main/utils', () => {
|
||||
expect(Utils.shouldHaveBackBar('https://server-1.com', 'https://server-1.com/login')).toBe(false);
|
||||
});
|
||||
});
|
||||
|
||||
describe('isStringWithLength', () => {
|
||||
it('should return true for valid string', () => {
|
||||
expect(Utils.isStringWithLength('string')).toBe(true);
|
||||
});
|
||||
it('should return false for empty string', () => {
|
||||
expect(Utils.isStringWithLength('')).toBe(false);
|
||||
});
|
||||
it('should return false for invalid inputs', () => {
|
||||
expect(
|
||||
Utils.isStringWithLength(null) ||
|
||||
Utils.isStringWithLength(undefined) ||
|
||||
Utils.isStringWithLength(1) ||
|
||||
Utils.isStringWithLength({}) ||
|
||||
Utils.isStringWithLength(() => {}),
|
||||
).toBe(false);
|
||||
});
|
||||
});
|
||||
|
||||
describe('getPercentage', () => {
|
||||
it('should return 0 if denominator is 0', () => {
|
||||
expect(Utils.getPercentage(1, 0)).toBe(0);
|
||||
});
|
||||
it('should return the correct percentage', () => {
|
||||
expect(Utils.getPercentage(2, 4)).toBe(50);
|
||||
});
|
||||
it('should return the correct percentage as integer', () => {
|
||||
expect(Utils.getPercentage(1, 3)).toBe(33);
|
||||
});
|
||||
});
|
||||
|
||||
describe('readFilenameFromContentDispositionHeader', () => {
|
||||
it('should read the filename from the HTTP Content-Disposition header\'s value', () => {
|
||||
expect(Utils.readFilenameFromContentDispositionHeader(['attachment; filename="filename.jpg"; foobar'])).toBe('filename.jpg');
|
||||
});
|
||||
});
|
||||
|
||||
describe('doubleSecToMs', () => {
|
||||
it('should convert a double number of seconds to integer milliseconds', () => {
|
||||
expect(Utils.doubleSecToMs(1662561807.067542)).toBe(1662561807068);
|
||||
});
|
||||
});
|
||||
|
||||
describe('shouldIncrementFilename', () => {
|
||||
it('should increment filename if file already exists', () => {
|
||||
expect(Utils.shouldIncrementFilename('filename.txt')).toBe('filename (1).txt');
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user