[MM-22239] Downloads dropdown (#2227)
* WIP: show/hide temp downloads dropdown * WIP: Position downloads dropdown correctly under the button * WIP: Use correct width for dropdown so that right radius and shadows are displayed * WIP: Add items to download list after finished downloading * WIP: Add download item base components * Add "clear all" functionality * Use type Record<> for downloads saved in config * Add styling to files in the downloads dropdown * Open file in folder when clicking it from downloads dropdown. Center svg in parent element * Update scrollbar styling * Update scrollbar styling * Update state of downloaded items if deleted from folder * Add progress bar in downloads * Use "x-uncompressed-content-length" in file downloads. * Keep downloads open when clicking outside their browserview * Use correct color for downloads dropdown button * Add better styling to downloads dropdown button * Allow only 50 download files maximum. Oldest file is being removed if reached * Autoclose downloads dropdown after 4s of download finish * Add file thumbnails * Dont show second dialog if first dismissed * Add red badge when downloads running and dropdown closed * Add menu item for Downloads * Add support for more code file extensions * Open downloads dropdown instead of folder from the menu * Run lint:js and fix problems * Add tests for utils * Fix issue with dropdown not displaying * Remove unecessary comment * Move downloads to separate json file, outside Config * Add downloads dropdown menu for the 3-dot button * Dont show dev tools for downloads * Add cancel download functionality * Add dark mode styling * Use View state for downloadsMenu open state * Fix some style issues * Add image preview for downloaded images * Remove extra devTool in weback config * Fix issue with paths on windows * Align items left in downloads menu * Use pretty-bytes for file sizes * Show download remaining time * Close downloads dropdown when clicking outside * Show different units in received bytes when they are different from the total units (kb/mb) * Dont hide downloads when mattermost view is clicked * Keep downloads open if download button is clicked * Use closest() to check for download clicks * Fix unit tests. Add tests for new Views and downloadManager Add @types/jest as devDependency for intellisense * Remove unecessary tsconfig for jest * Fix types error * Add all critical tests for downloadsManager * WIP: add e2e tests for downloads * WIP: add e2e tests for downloads * Rename downloads spec file * WIP: make vscode debugger work for e2e tests * Remove unused mock * Remove defaults for v4 config * Use electron-mocha for e2e debugger * Fix e2e tests spawning JsonFileManager twice * Add async fs functions and add tests for download item UI * Add async fs functions and add tests for download item UI * Improve tests with "waitForSelector" to wait for visible elements * Wait for page load before assertions * Add tests for file uploads/downloads * Dont show native notification for completed downloads if dropdown is open * Increment filenames if file already exists * Fix antializing in downloads dropdown * Fix styling of downloads header * Increase dimensions of green/red icons in downloads * Fix styling of 3-dot button * Fix unit tests * Show 3-dot button only on hover or click * PR review fixes * Revert vscode debug fixes * Mock fs.constants * Mock fs instead of JsonFileManager in downlaods tests * Mock fs instead of JsonFileManager in downlaods tests * Add necessary mocks for downloads manager * Mark file as deleted if user deleted it * Fix min-height of downloads dropdown and 3-dot icon position * Add more tests * Make size of downloads dropdown dynamic based on content * Combine log statements * Close 3-dot menu if user clicks elsewhere * Move application updates inside downloads dropdown * Fix update issues * Fix ipc event payload * Add missing prop * Remove unused translations * Fix failing test * Fix version unknown * Remove commented out component
This commit is contained in:
Tasos Boulis
194
src/main/downloadsManager.test.js
Normal file
194
src/main/downloadsManager.test.js
Normal file
@@ -0,0 +1,194 @@
|
||||
// Copyright (c) 2016-present Mattermost, Inc. All Rights Reserved.
|
||||
// See LICENSE.txt for license information.
|
||||
import path from 'path';
|
||||
import fs from 'fs';
|
||||
|
||||
import {shell} from 'electron';
|
||||
|
||||
import {getDoNotDisturb as getDarwinDoNotDisturb} from 'macos-notification-state';
|
||||
|
||||
import {DownloadsManager} from 'main/downloadsManager';
|
||||
|
||||
const downloadLocationMock = '/path/to/downloads';
|
||||
const locationMock = '/some/dir/file.txt';
|
||||
const locationMock1 = '/downloads/file1.txt';
|
||||
jest.mock('electron', () => {
|
||||
class NotificationMock {
|
||||
static isSupported = jest.fn();
|
||||
static didConstruct = jest.fn();
|
||||
constructor() {
|
||||
NotificationMock.didConstruct();
|
||||
}
|
||||
on = jest.fn();
|
||||
show = jest.fn();
|
||||
click = jest.fn();
|
||||
close = jest.fn();
|
||||
}
|
||||
return {
|
||||
app: {
|
||||
getAppPath: jest.fn(),
|
||||
},
|
||||
BrowserView: jest.fn().mockImplementation(() => ({
|
||||
webContents: {
|
||||
loadURL: jest.fn(),
|
||||
focus: jest.fn(),
|
||||
send: jest.fn(),
|
||||
},
|
||||
setBounds: jest.fn(),
|
||||
})),
|
||||
ipcMain: {
|
||||
emit: jest.fn(),
|
||||
handle: jest.fn(),
|
||||
on: jest.fn(),
|
||||
},
|
||||
Menu: {
|
||||
getApplicationMenu: () => ({
|
||||
getMenuItemById: jest.fn(),
|
||||
}),
|
||||
},
|
||||
Notification: NotificationMock,
|
||||
session: {
|
||||
defaultSession: {
|
||||
on: jest.fn(),
|
||||
},
|
||||
},
|
||||
shell: {
|
||||
showItemInFolder: jest.fn(),
|
||||
openPath: jest.fn(),
|
||||
},
|
||||
};
|
||||
});
|
||||
jest.mock('path', () => {
|
||||
const original = jest.requireActual('path');
|
||||
return {
|
||||
...original,
|
||||
resolve: jest.fn(),
|
||||
parse: jest.fn(),
|
||||
};
|
||||
});
|
||||
jest.mock('fs', () => ({
|
||||
existsSync: jest.fn().mockReturnValue(false),
|
||||
readFileSync: jest.fn().mockImplementation((text) => text),
|
||||
writeFile: jest.fn(),
|
||||
}));
|
||||
jest.mock('macos-notification-state', () => ({
|
||||
getDoNotDisturb: jest.fn(),
|
||||
}));
|
||||
jest.mock('main/windows/windowManager', () => ({
|
||||
sendToRenderer: jest.fn(),
|
||||
}));
|
||||
jest.mock('common/config', () => {
|
||||
const original = jest.requireActual('common/config');
|
||||
return {
|
||||
...original,
|
||||
downloadLocation: downloadLocationMock,
|
||||
};
|
||||
});
|
||||
|
||||
const downloadsJson = {
|
||||
'file1.txt': {
|
||||
addedAt: 1662545584346,
|
||||
filename: 'file1.txt',
|
||||
mimeType: 'text/plain',
|
||||
location: '/downloads/file1.txt',
|
||||
progress: 100,
|
||||
receivedBytes: 5425,
|
||||
state: 'completed',
|
||||
totalBytes: 5425,
|
||||
type: 'file',
|
||||
},
|
||||
'file2.txt': {
|
||||
addedAt: 1662545588346,
|
||||
filename: 'file2.txt',
|
||||
mimeType: 'text/plain',
|
||||
location: '/downloads/file2.txt',
|
||||
progress: 100,
|
||||
receivedBytes: 5425,
|
||||
state: 'cancelled',
|
||||
totalBytes: 5425,
|
||||
type: 'file',
|
||||
},
|
||||
};
|
||||
const nowSeconds = Date.now() / 1000;
|
||||
const item = {
|
||||
getFilename: () => 'file.txt',
|
||||
getMimeType: () => 'text/plain',
|
||||
getReceivedBytes: () => 2121,
|
||||
getStartTime: () => nowSeconds,
|
||||
getTotalBytes: () => 4242,
|
||||
getSavePath: () => locationMock,
|
||||
setSavePath: jest.fn(),
|
||||
on: jest.fn(),
|
||||
setSaveDialogOptions: jest.fn(),
|
||||
once: jest.fn(),
|
||||
location: locationMock,
|
||||
};
|
||||
const item1 = {
|
||||
...item,
|
||||
getFilename: () => 'file1.txt',
|
||||
getSavePath: () => locationMock1,
|
||||
location: locationMock1,
|
||||
};
|
||||
describe('main/downloadsManager', () => {
|
||||
beforeEach(() => {
|
||||
getDarwinDoNotDisturb.mockReturnValue(false);
|
||||
});
|
||||
|
||||
it('should be initialized', () => {
|
||||
expect(new DownloadsManager({})).toHaveProperty('downloads', {});
|
||||
});
|
||||
it('should mark "completed" files that were deleted as "deleted"', () => {
|
||||
expect(new DownloadsManager(JSON.stringify(downloadsJson))).toHaveProperty('downloads', {...downloadsJson, 'file1.txt': {...downloadsJson['file1.txt'], state: 'deleted'}});
|
||||
});
|
||||
it('should handle a new download', () => {
|
||||
const dl = new DownloadsManager({});
|
||||
path.parse.mockImplementation(() => ({base: 'file.txt'}));
|
||||
dl.handleNewDownload({}, item, {id: 0, getURL: jest.fn()});
|
||||
expect(dl).toHaveProperty('downloads', {'file.txt': {
|
||||
addedAt: nowSeconds * 1000,
|
||||
filename: 'file.txt',
|
||||
mimeType: 'text/plain',
|
||||
location: '/some/dir/file.txt',
|
||||
progress: 50,
|
||||
receivedBytes: 2121,
|
||||
state: 'progressing',
|
||||
totalBytes: 4242,
|
||||
type: 'file',
|
||||
}});
|
||||
});
|
||||
|
||||
it('should monitor network to retrieve the file size of downloading items', () => {
|
||||
const dl = new DownloadsManager({});
|
||||
const details = {
|
||||
responseHeaders: {
|
||||
'content-encoding': ['gzip'],
|
||||
'x-uncompressed-content-length': ['4242'],
|
||||
'content-disposition': ['attachment; filename="file.txt"; foobar'],
|
||||
},
|
||||
};
|
||||
dl.webRequestOnHeadersReceivedHandler(details, jest.fn());
|
||||
expect(dl.fileSizes.get('file.txt')).toBe('4242');
|
||||
});
|
||||
|
||||
it('should clear the downloads list', () => {
|
||||
const dl = new DownloadsManager(JSON.stringify(downloadsJson));
|
||||
dl.clearDownloadsDropDown();
|
||||
expect(dl).toHaveProperty('downloads', {});
|
||||
});
|
||||
|
||||
it('should open downloads folder if file deleted', () => {
|
||||
const dl = new DownloadsManager(JSON.stringify(downloadsJson));
|
||||
path.parse.mockImplementation(() => ({base: 'file1.txt'}));
|
||||
dl.showFileInFolder(item1);
|
||||
expect(shell.openPath).toHaveBeenCalledWith(downloadLocationMock);
|
||||
});
|
||||
|
||||
it('should show the file in the downloads folder', () => {
|
||||
const dl = new DownloadsManager(JSON.stringify(downloadsJson));
|
||||
fs.existsSync.mockReturnValueOnce(true);
|
||||
path.parse.mockImplementation(() => ({base: 'file1.txt'}));
|
||||
dl.showFileInFolder(item1);
|
||||
expect(shell.showItemInFolder).toHaveBeenCalledWith(locationMock1);
|
||||
});
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user