[MM-22239] Downloads dropdown (#2227)
* WIP: show/hide temp downloads dropdown * WIP: Position downloads dropdown correctly under the button * WIP: Use correct width for dropdown so that right radius and shadows are displayed * WIP: Add items to download list after finished downloading * WIP: Add download item base components * Add "clear all" functionality * Use type Record<> for downloads saved in config * Add styling to files in the downloads dropdown * Open file in folder when clicking it from downloads dropdown. Center svg in parent element * Update scrollbar styling * Update scrollbar styling * Update state of downloaded items if deleted from folder * Add progress bar in downloads * Use "x-uncompressed-content-length" in file downloads. * Keep downloads open when clicking outside their browserview * Use correct color for downloads dropdown button * Add better styling to downloads dropdown button * Allow only 50 download files maximum. Oldest file is being removed if reached * Autoclose downloads dropdown after 4s of download finish * Add file thumbnails * Dont show second dialog if first dismissed * Add red badge when downloads running and dropdown closed * Add menu item for Downloads * Add support for more code file extensions * Open downloads dropdown instead of folder from the menu * Run lint:js and fix problems * Add tests for utils * Fix issue with dropdown not displaying * Remove unecessary comment * Move downloads to separate json file, outside Config * Add downloads dropdown menu for the 3-dot button * Dont show dev tools for downloads * Add cancel download functionality * Add dark mode styling * Use View state for downloadsMenu open state * Fix some style issues * Add image preview for downloaded images * Remove extra devTool in weback config * Fix issue with paths on windows * Align items left in downloads menu * Use pretty-bytes for file sizes * Show download remaining time * Close downloads dropdown when clicking outside * Show different units in received bytes when they are different from the total units (kb/mb) * Dont hide downloads when mattermost view is clicked * Keep downloads open if download button is clicked * Use closest() to check for download clicks * Fix unit tests. Add tests for new Views and downloadManager Add @types/jest as devDependency for intellisense * Remove unecessary tsconfig for jest * Fix types error * Add all critical tests for downloadsManager * WIP: add e2e tests for downloads * WIP: add e2e tests for downloads * Rename downloads spec file * WIP: make vscode debugger work for e2e tests * Remove unused mock * Remove defaults for v4 config * Use electron-mocha for e2e debugger * Fix e2e tests spawning JsonFileManager twice * Add async fs functions and add tests for download item UI * Add async fs functions and add tests for download item UI * Improve tests with "waitForSelector" to wait for visible elements * Wait for page load before assertions * Add tests for file uploads/downloads * Dont show native notification for completed downloads if dropdown is open * Increment filenames if file already exists * Fix antializing in downloads dropdown * Fix styling of downloads header * Increase dimensions of green/red icons in downloads * Fix styling of 3-dot button * Fix unit tests * Show 3-dot button only on hover or click * PR review fixes * Revert vscode debug fixes * Mock fs.constants * Mock fs instead of JsonFileManager in downlaods tests * Mock fs instead of JsonFileManager in downlaods tests * Add necessary mocks for downloads manager * Mark file as deleted if user deleted it * Fix min-height of downloads dropdown and 3-dot icon position * Add more tests * Make size of downloads dropdown dynamic based on content * Combine log statements * Close 3-dot menu if user clicks elsewhere * Move application updates inside downloads dropdown * Fix update issues * Fix ipc event payload * Add missing prop * Remove unused translations * Fix failing test * Fix version unknown * Remove commented out component
This commit is contained in:
Tasos Boulis
@@ -15,7 +15,7 @@ const {ipcRenderer} = require('electron');
|
||||
|
||||
const {SHOW_SETTINGS_WINDOW} = require('../../src/common/communication');
|
||||
|
||||
const {asyncSleep} = require('./utils');
|
||||
const {asyncSleep, mkDirAsync, rmDirAsync, unlinkAsync} = require('./utils');
|
||||
chai.should();
|
||||
|
||||
const sourceRootDir = path.join(__dirname, '../..');
|
||||
@@ -28,6 +28,8 @@ const electronBinaryPath = (() => {
|
||||
})();
|
||||
const userDataDir = path.join(sourceRootDir, 'e2e/testUserData/');
|
||||
const configFilePath = path.join(userDataDir, 'config.json');
|
||||
const downloadsFilePath = path.join(userDataDir, 'downloads.json');
|
||||
const downloadsLocation = path.join(userDataDir, 'Downloads');
|
||||
const boundsInfoPath = path.join(userDataDir, 'bounds-info.json');
|
||||
const appUpdatePath = path.join(userDataDir, 'app-update.yml');
|
||||
const exampleURL = 'http://example.com/';
|
||||
@@ -51,12 +53,10 @@ const exampleTeam = {
|
||||
{
|
||||
name: 'TAB_FOCALBOARD',
|
||||
order: 1,
|
||||
isOpen: true,
|
||||
},
|
||||
{
|
||||
name: 'TAB_PLAYBOOKS',
|
||||
order: 2,
|
||||
isOpen: true,
|
||||
},
|
||||
],
|
||||
lastActiveTab: 0,
|
||||
@@ -100,10 +100,14 @@ const demoConfig = {
|
||||
useSpellChecker: true,
|
||||
enableHardwareAcceleration: true,
|
||||
autostart: true,
|
||||
hideOnStart: false,
|
||||
spellCheckerLocales: [],
|
||||
darkMode: false,
|
||||
lastActiveTeam: 0,
|
||||
spellCheckerLocales: [],
|
||||
startInFullscreen: false,
|
||||
autoCheckForUpdates: false,
|
||||
appLanguage: 'en',
|
||||
logLevel: 'silly',
|
||||
};
|
||||
|
||||
const demoMattermostConfig = {
|
||||
@@ -119,6 +123,8 @@ const cmdOrCtrl = process.platform === 'darwin' ? 'command' : 'control';
|
||||
module.exports = {
|
||||
sourceRootDir,
|
||||
configFilePath,
|
||||
downloadsFilePath,
|
||||
downloadsLocation,
|
||||
userDataDir,
|
||||
boundsInfoPath,
|
||||
appUpdatePath,
|
||||
@@ -147,7 +153,7 @@ module.exports = {
|
||||
},
|
||||
|
||||
cleanTestConfig() {
|
||||
[configFilePath, boundsInfoPath].forEach((file) => {
|
||||
[configFilePath, downloadsFilePath, boundsInfoPath].forEach((file) => {
|
||||
try {
|
||||
fs.unlinkSync(file);
|
||||
} catch (err) {
|
||||
@@ -158,6 +164,13 @@ module.exports = {
|
||||
}
|
||||
});
|
||||
},
|
||||
async cleanTestConfigAsync() {
|
||||
await Promise.all(
|
||||
[configFilePath, downloadsFilePath, boundsInfoPath].map((file) => {
|
||||
return unlinkAsync(file);
|
||||
}),
|
||||
);
|
||||
},
|
||||
|
||||
cleanDataDir() {
|
||||
try {
|
||||
@@ -169,28 +182,35 @@ module.exports = {
|
||||
}
|
||||
}
|
||||
},
|
||||
cleanDataDirAsync() {
|
||||
return rmDirAsync(userDataDir);
|
||||
},
|
||||
|
||||
createTestUserDataDir() {
|
||||
if (!fs.existsSync(userDataDir)) {
|
||||
fs.mkdirSync(userDataDir);
|
||||
}
|
||||
},
|
||||
async createTestUserDataDirAsync() {
|
||||
await mkDirAsync(userDataDir);
|
||||
},
|
||||
|
||||
async getApp(args = []) {
|
||||
const options = {
|
||||
downloadsPath: downloadsLocation,
|
||||
env: {
|
||||
...process.env,
|
||||
RESOURCES_PATH: userDataDir,
|
||||
},
|
||||
executablePath: electronBinaryPath,
|
||||
args: [`${path.join(sourceRootDir, 'dist')}`, `--data-dir=${userDataDir}`, '--disable-dev-mode', ...args],
|
||||
args: [`${path.join(sourceRootDir, 'dist')}`, `--user-data-dir=${userDataDir}`, '--disable-dev-mode', ...args],
|
||||
};
|
||||
|
||||
// if (process.env.MM_DEBUG_SETTINGS) {
|
||||
// options.chromeDriverLogPath = './chromedriverlog.txt';
|
||||
// }
|
||||
// if (process.platform === 'darwin' || process.platform === 'linux') {
|
||||
// // on a mac, debbuging port might conflict with other apps
|
||||
// // on a mac, debugging port might conflict with other apps
|
||||
// // this changes the default debugging port so chromedriver can run without issues.
|
||||
// options.chromeDriverArgs.push('remote-debugging-port=9222');
|
||||
//}
|
||||
@@ -242,6 +262,27 @@ module.exports = {
|
||||
await window.click('#saveSetting');
|
||||
},
|
||||
|
||||
async openDownloadsDropdown(app) {
|
||||
const mainWindow = app.windows().find((window) => window.url().includes('index'));
|
||||
await mainWindow.waitForLoadState();
|
||||
await mainWindow.bringToFront();
|
||||
|
||||
const dlButtonLocator = await mainWindow.waitForSelector('.DownloadsDropdownButton');
|
||||
await dlButtonLocator.click();
|
||||
await asyncSleep(500);
|
||||
|
||||
const downloadsWindow = app.windows().find((window) => window.url().includes('downloadsDropdown'));
|
||||
await downloadsWindow.waitForLoadState();
|
||||
await downloadsWindow.bringToFront();
|
||||
return downloadsWindow;
|
||||
},
|
||||
|
||||
async downloadsDropdownIsOpen(app) {
|
||||
const downloadsWindow = app.windows().find((window) => window.url().includes('downloadsDropdown'));
|
||||
const result = await downloadsWindow.isVisible('.DownloadsDropdown');
|
||||
return result;
|
||||
},
|
||||
|
||||
addClientCommands(client) {
|
||||
client.addCommand('loadSettingsPage', function async() {
|
||||
ipcRenderer.send(SHOW_SETTINGS_WINDOW);
|
||||
|
||||
Reference in New Issue
Block a user