phlux/mattermostest
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Improve error messages on add new server dialog

Browse Source 
Closes #438

Note: this solution is different than what @jasonblais suggested.
@jasonblais suggested not highlighting the field that hasn't been
filled out yet, but I think it's a better UX to continue to highlight
them all as it currently does, but to clarify the error messages. Also
notably, as far as I can tell, the react-bootstrap [forms
API](https://react-bootstrap.github.io/components/forms/) does not
appear to support selectively highlighting some fields in the form but
not others anyway.
This commit is contained in:
Eric Newport
2018-04-27 11:34:57 -04:00
parent 9c83d4009c
commit 007a64525b
2 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
CHANGELOG.md
View File

@@ -50,6 +50,8 @@ Release date: TBD
[#707](https://github.com/mattermost/desktop/issues/707)
- Fixed an issue that prevented typing in the form fields on the add server dialog when launched from the tab bar.
[#780](https://github.com/mattermost/desktop/issues/780)
- Fixed an issue that could cause an error message on the add new server dialog to be misleading.
[#438](https://github.com/mattermost/desktop/issues/438)
#### Windows
- Fixed `file://` protocol not working. But localhost URL will not continue to work.